Issue #4437: Modified UnusedImportsCheckTest.java and moved its input files to the unusedimports subdirectory #4470
Conversation
| } | ||
|
|
||
| @Test | ||
| public void testAnnotations() throws Exception { | ||
| final DefaultConfiguration checkConfig = createCheckConfig(UnusedImportsCheck.class); | ||
| final String[] expected = CommonUtils.EMPTY_STRING_ARRAY; | ||
| verify(checkConfig, getNonCompilablePath("package-info.java"), expected); | ||
| verify(checkConfig, getNonCompilablePath("InputUnusedImportsAnnotations.java"), expected); |
There was a problem hiding this comment.
please restore name of the file - it is special file.
https://www.intertech.com/Blog/whats-package-info-java-for/
There was a problem hiding this comment.
@romani It is still an input file. If test doesn't rely on requiring a specific file name, why must we keep it like that?
There was a problem hiding this comment.
ok, lets keep new name. Checkstyle do not care, it was just signal to used that file was weird because it is non java file actually.
package-info.java - is parse-able by us, that is why we process it. In other words , it does not make problems for us so we work with it.
module-info.java - is in the same family of file in java project. We do not process it, because it completely different by structure and .... .
so, to make it clear for future contributor, lets change comment content from Annotated package definition to check if import is declared unused --> this file content is based on package-info.java file structure
| import java.lang.String; | ||
| import static java.lang.Math.PI; | ||
|
|
||
| public class InputRedundantImport_UnnamedPackage |
… its input files to the unusedimports subdirectory
subkrish
force-pushed
the
fix-issue-4437-unusedimports
branch
from
a419328
to
131ea14
Compare
Issue #4437
This PR moves all inputs of UnusedImportsCheckTest of the imports package to a new subdirectory 'unusedimports'.