Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4035: Rename STMT in BlockOption class to STATEMENT #4482

Merged
merged 1 commit into from Jun 23, 2017

Conversation

subkrish
Copy link
Contributor

@subkrish subkrish commented Jun 21, 2017

Issue #4035

Renamed STMT in BlockOption class to STATEMENT. Also made subsequent changes in the EmptyBlockCheck, EmptyBlockCheckTest, config_blocks.xml, property_types.xml and messages.properties.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more files to update:
checkstyle/src/xdocs/config_blocks.xml
checkstyle/src/xdocs/property_types.xml

please search in repo for all "stmt". Not all probably should be changed , but should be reviewed for sure.

@subkrish
Copy link
Contributor Author

subkrish commented Jun 21, 2017

I did update config_blocks.xml. I will make necessary changes for property_types.xml

@subkrish
Copy link
Contributor Author

Done.

@romani @rnveach Please review.

@rnveach
Copy link
Member

rnveach commented Jun 22, 2017

@subkrish Please rebase on latest master so we can test a travis fix.

@subkrish
Copy link
Contributor Author

Rebased on latest master. Done.

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #4482 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4482   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         285     285           
  Lines       15324   15324           
  Branches     3489    3489           
======================================
  Hits        15324   15324
Impacted Files Coverage Δ
...wl/tools/checkstyle/checks/blocks/BlockOption.java 100% <100%> (ø) ⬆️
...ools/checkstyle/checks/blocks/EmptyBlockCheck.java 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72e6f7...cef09db. Read the comment docs.

@rnveach rnveach requested a review from romani June 22, 2017 17:11
@romani romani merged commit fdb2140 into checkstyle:master Jun 23, 2017
@subkrish subkrish deleted the fix-issue-4035 branch June 23, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants