Issue #4707: fixed abstraction IDEA violations #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnveach
reviewed
Jul 14, 2017
| @@ -437,6 +437,9 @@ public void finishLocalSetup() throws CheckstyleException { | |||
| childContext = context; | |||
| } | |||
|
|
|||
| /** | |||
| * @noinspection ChainOfInstanceofChecks. | |||
There was a problem hiding this comment.
Shouldn't this still start with {@inheritDoc} since it is an overridden method and you are not re-defining the description?
config/intellij-idea-inspections.xml
Outdated
| @@ -1929,6 +1940,7 @@ | |||
| <option name="m_minLength" value="4" /> | |||
| <option name="m_maxLength" value="64" /> | |||
| </inspection_tool> | |||
| <!-- we are a library, not used my us heavily does not mean that is not required --> | |||
|
wercker is relaunched, TC should be fixed. |
Codecov Report
@@ Coverage Diff @@
## master #4718 +/- ##
======================================
Coverage 100% 100%
======================================
Files 287 287
Lines 15386 15386
Branches 3501 3501
======================================
Hits 15386 15386
Continue to review full report at Codecov.
|
romani
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4707
fixed all IDEA violations from this report
except BooleanParameter which will be addressed in #4709