Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3891: removed inputs out of non-existent misc package #5120

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Sep 17, 2017

Issue #3891

Removed misc folder and moved all sub-folders one level up.

@codecov-io
Copy link

codecov-io commented Sep 17, 2017

Codecov Report

Merging #5120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5120   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         294     294           
  Lines       16037   16037           
  Branches     3632    3632           
======================================
  Hits        16037   16037

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f804efa...fbbf46a. Read the comment docs.

@rnveach rnveach requested a review from romani September 17, 2017 17:16
@rnveach
Copy link
Member Author

rnveach commented Sep 19, 2017

@romani ping

@romani
Copy link
Member

romani commented Sep 21, 2017

@rnveach , are you sure that it will better ?
does smth force you to make such change ?

@rnveach
Copy link
Member Author

rnveach commented Sep 21, 2017

@romani The UT I made to make sure everything is in it's place by the rules we set out is asking for this change.
The rules we set out was that inputs have to be in a sub-directory of the test's package and named as a as a short hand of the test.

It will be slightly odd if we have one package that does something different then all the others.
If you want misc to stay, I can try and change the UT around it.

@romani romani merged commit 3341fd3 into checkstyle:master Sep 21, 2017
@romani
Copy link
Member

romani commented Sep 21, 2017

ok, one day we will make "misc" in betrer form

@rnveach rnveach deleted the issue_3891_17 branch September 21, 2017 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants