Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5003: remove ParenPad#processExpression call where it seems useless #5217

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

Nimfadora
Copy link
Contributor

@Nimfadora Nimfadora commented Oct 22, 2017

Issue #5003

remove calls to processExpression, as pitest claims (here and here) that they are useless

regression report

@romani
Copy link
Member

romani commented Oct 22, 2017

appveyor problem is the same as #5173 , unrelated ans could be ignored, I will try to reset cache one more time.

@Nimfadora , please provide diff report to prove no simple regression.

@codecov-io
Copy link

codecov-io commented Oct 23, 2017

Codecov Report

Merging #5217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5217   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         296     296           
  Lines       16097   16095    -2     
  Branches     3641    3641           
======================================
- Hits        16097   16095    -2
Impacted Files Coverage Δ
...ls/checkstyle/checks/whitespace/ParenPadCheck.java 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c33c7...4ae64f6. Read the comment docs.

@romani romani merged commit 0f5b821 into checkstyle:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants