Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6403: fixed bad regular expression when only doing a find #6404

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Issue #6403: fixed bad regular expression when only doing a find #6404

merged 1 commit into from
Feb 3, 2019

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Feb 2, 2019 •
edited
Loading

Issue #6403

Regression to come.

Fun little note, originally I changed .*? to .* and the execution time doubled. I find it weird how much the ? help.

@rnveach
Copy link
Member Author

rnveach commented Feb 2, 2019

Regression: http://rveach.no-ip.org/checkstyle/regression/reports/226/

No differences. These were the only 2 checks I saw call this utility.

These were the results when run with the DebugListener:

Starting audit...
------------------
Run Time: 31.548

...

Checks: (141)
...
UnusedImportsCheck	448037	0.415	0.0	0.007	0.0
...

@rnveach
Copy link
Member Author

rnveach commented Feb 2, 2019

CI failure is only because issue isn't approved.

@rnveach rnveach requested a review from romani February 2, 2019 17:04
@romani romani merged commit 04a567d into checkstyle:master Feb 3, 2019
@rnveach rnveach deleted the inlinetagutil_fix branch February 3, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani Awaiting requested review from romani

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnveach @romani