Issue #405: exception during workbench shutdown #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid a static block for creating the icon images, since we cannot really control when that static block is executed (it depends on the class loading time). Rather create the icons the first time they are needed, since that is surely when the workbench is fully up and running.
romani
reviewed
Nov 18, 2022
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| /** | |||
| * Image provider for Checkstyle markers. | |||
| * | |||
| * | |||
There was a problem hiding this comment.
Sounds like auto formatting.
Is it possible to auto format whole project ones to avoid such extra changes in future?
There was a problem hiding this comment.
Yes, that's why I have it quite high in the bullet point list of #388. I also don't like reviews that contain whitespace and formatting changes.
Calixte
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a static block for creating the icon images, since we cannot really control when that static block is executed (it depends on the class loading time). Rather create the icons the first time they are accessed, since that is surely when the workbench is fully up and running.
Have tested configuration, execution, markers. Works as before, no more exception.