upgrade squid bridge

[hypery2k]

Issue #157 upgrade squid bridge

[rnveach]

Will this cause issues with checkstyle as it uses guava 26? Why do we need this dependency if no code was changed?

[rnveach]

@hypery2k CI must be green.

File 'pom.xml' uses tabs for indentation

@romani wercker error:

[ERROR] SonarQube server [http://localhost:9000] can not be reached

[hypery2k]

did you have a formatter for IDEA?

[rnveach]

@hypery2k I'm not sure I understand your question. It isn't a formatter, it is just asking to use spaces instead of tabs for indentation. This should be a simple change using notepad or such. Just follow formatting of similar items around it.

[hypery2k]

I cannot get the CI build green, as either team city or checkstyle will complain about this. And I didn't changed anything there...

[rnveach]

weird it was only complaining about the indentation before. It looks like it is related to the new TC version.

[aepfli]

is it possible to support somehow? i am not sure how to fix it, but at least i understand the problem in CheckstyleExecutor with "Call to 'Collection.toArray()' with zero-length array argument (1)"

sonar-checkstyle/checkstyle-sonar-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java

Line 146 in 010d408

return new URLClassLoader(urls.toArray(new URL[urls.size()]), null);

but a good suggestion based on h2database/h2database#311 would be to change the line simply to return new URLClassLoader(urls.toArray(new URL[0]), null);

[rnveach]

would be to change the line simply to return new URLClassLoader(urls.toArray(new URL[0]), null);

Yes, this is the change that would have to be made.

[hypery2k]

with the proposed changes I then get maven pmd errors:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.7:check (default) on project checkstyle-sonar-plugin: You have 1 PMD violation. For more details see: /Users/mreinhardt/Documents/Programmierung/repositories/git/job/sonar-checkstyle/checkstyle-sonar-plugin/target/pmd.xml -> [Help 1]

[rnveach]

@hypery2k You would have to show us the PMD error as that is all the error shows. Most likely it isn't related to your PR but TC changed between the last master and now.

[hypery2k]

see here:

<?xml version="1.0" encoding="UTF-8"?>
<pmd version="5.5.1" timestamp="2018-09-24T16:27:44.057">
<file name="/Users/mreinhardt/Documents/Programmierung/repositories/git/job/sonar-checkstyle/checkstyle-sonar-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java">
<violation beginline="146" endline="146" begincolumn="35" endcolumn="58" rule="OptimizableToArrayCall" ruleset="Design" package="org.sonar.plugins.checkstyle" class="CheckstyleExecutor" method="createClassloader" externalInfoUrl="https://pmd.github.io/pmd-5.5.1/pmd-java/rules/java/design.html#OptimizableToArrayCall" priority="3">
This call to Collection.toArray() may be optimizable
</violation>
</file>
</pmd>

[aepfli]

Well I do think that this pmd rule, based on the link I posted is not 100% valid ;) - I am not a contributor to sonar-checkstyle, but can we deactivate this rule?

[rnveach]

Main repo uses the same IDEA and PMD doesn't complain there, so I am trying to reconcile the 2. See #159 . Sorry for delay.

[romani]

@hypery2k , I apologize for delay in response.

Please squash all commits in one and rebase latest master (we recently merged some fixes for CI), and will continue investigate what else is required to make this PR be merged.

Please also make some comments in issue about what need to be changed in code to let us validate a fix. We need help from you.

[rnveach]

@hypery2k ping

[romani]

closed in favor of #165