Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #160: fix teamcity violations #159

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Sep 26, 2018

#160 and the start of #161

@rnveach rnveach mentioned this pull request Sep 26, 2018
@rnveach rnveach changed the title minor: test CI Issue #160: fix teamcity violations Sep 26, 2018
@rnveach
Copy link
Member Author

rnveach commented Sep 26, 2018

PMD violation:

[INFO] --- maven-pmd-plugin:3.7:check (default) @ checkstyle-sonar-plugin ---
[INFO] PMD Failure: org.sonar.plugins.checkstyle.CheckstyleExecutor:146 Rule:OptimizableToArrayCall Priority:3 This call to Collection.toArray() may be optimizable.

@rnveach
Copy link
Member Author

rnveach commented Sep 27, 2018

teamcity is still failing with:

Zero-length array allocation (1)
146: createClassloader() Allocation of zero length array

@rnveach
Copy link
Member Author

rnveach commented Sep 27, 2018

Everything is passing. I will fix commits.

@rnveach rnveach requested a review from romani September 27, 2018 02:41
@romani
Copy link
Member

romani commented Oct 4, 2018

@rnveach , please review issues if they are ok to be closed.

@rnveach rnveach deleted the test branch October 4, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants