Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrity information in package-lock.json #341

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

natsukagami
Copy link
Contributor

This was done with https://github.com/jeslie0/npm-lockfile-fix

Context

npm doesn't do the most stellar job when it comes to specifying the full integrity information (hashes and such)
inside the package-lock.json file. See more details at NixOS/nixpkgs#261137
This makes building the package from a Nix context really hard (the issue above gives one such instance), and
this applies to your repo too :(

What I did

npm-lockfile-fix adds the hash of each package into the lock file. You can verify this all works (and is valid) by just doing
npm install.

Unfortunately this doesn't guarantee that npm won't mess it up again in the future, but I frankly have no idea
what to do until upstream issues get fixed :(

@cheeaun cheeaun merged commit bfcb314 into cheeaun:main Dec 3, 2023
2 checks passed
@natsukagami natsukagami deleted the fix-pkg-lock-integrity branch December 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants