workaround for PhantomJS lying about touch support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporary(?) fix for PhantomJS Issue #375 - http://code.google.com/p/phantomjs/issues/detail?id=375
|
Not sure about this, but shouldn't it be a bug in PhantomJS instead? |
|
I know, doesn't feel right. I just had to make this temporary change because of a project I'm working on, lost a lot of time trying to figure out what was going on, thought I'd 'ask you' if you want to include it as a temporary fix for other people. Feel free to reject it, cheers! |
* previously only the Y axis was handled, made accidental taps on horizontal lists very frequent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary(?) fix for PhantomJS Issue #375 - http://code.google.com/p/phantomjs/issues/detail?id=375
Basically had some integration tests failing because of this, tappable would use TouchEvents but Phantom didn't actually support them..
Lemme know what you think, cheers.