Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added some tests #1653

Merged
merged 2 commits into from Jan 5, 2021
Merged

added some tests #1653

merged 2 commits into from Jan 5, 2021

Conversation

5saviahv
Copy link
Contributor

@5saviahv 5saviahv commented Jan 5, 2021

  • eslint ignore jest/expect-expect
  • I tried add some diversity with tests

fb55
fb55 reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@fb55 fb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions! Two comments, otherwise this is great.

test/cheerio.js Outdated Show resolved Hide resolved
test/api/attributes.js Outdated Show resolved Hide resolved
@fb55 fb55 merged commit 1ebe05a into cheeriojs:main Jan 5, 2021
@fb55
Copy link
Member

fb55 commented Jan 5, 2021

Great PR 👏

@5saviahv 5saviahv deleted the tests branch January 5, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fb55 fb55 fb55 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@5saviahv @fb55