Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent find from returning duplicate elements #289

Merged
merged 1 commit into from
Oct 29, 2013

Conversation

jugglinmike
Copy link
Member

No description provided.

@davidchambers
Copy link
Contributor

LGTM. You're on a roll, @jugglinmike. Taking full advantage of Underscore, too. :)

@fb55
Copy link
Member

fb55 commented Oct 29, 2013

That's a CSSselect bug. I'll look into it.

@jugglinmike
Copy link
Member Author

Ah, I didn't consider that possibility. Thanks for keeping on top of this, @fb55!

@davidchambers
Copy link
Contributor

That's a CSSselect bug. I'll look into it.

We could merge this pull request, and one day replace this change to find with an update to the cheerio-select dependency in package.json. The test case is good to have regardless.

@jugglinmike
Copy link
Member Author

We could merge this pull request, and one day replace this change to find with an update to the cheerio-select dependency in package.json. The test case is good to have regardless.

Sounds good to me! I've updated the patch to document this.

@davidchambers
Copy link
Contributor

I've updated the patch to document this.

Good idea.

Merge at will. :)

@jugglinmike jugglinmike merged commit 2a643e6 into cheeriojs:master Oct 29, 2013
@jugglinmike jugglinmike deleted the remove-find-dupes branch October 29, 2013 23:24
@jugglinmike
Copy link
Member Author

Alrighty, thanks @davidchambers and @fb55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants