Skip to content
This repository has been archived by the owner on Apr 7, 2018. It is now read-only.

Commit

Permalink
Fixing up merge errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Sean OMeara committed Dec 22, 2013
1 parent ef5d913 commit 279321b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion providers/package.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def load_current_resource
software_license_agreement = system("hdiutil imageinfo #{passphrase_cmd} '#{dmg_file}' | grep -q 'Software License Agreement: true'")
fail "Requires EULA Acceptance; add 'accept_eula true' to package resource" if software_license_agreement && !new_resource.accept_eula
accept_eula_cmd = new_resource.accept_eula ? 'echo Y |' : ''
system "#{accept_eula_cmd} hdiutil attach #{passphrase_cmd} '#{dmg_file}'"
puts "#{accept_eula_cmd} hdiutil attach #{passphrase_cmd} '#{dmg_file}'"

This comment has been minimized.

Copy link
@jeroenj

jeroenj Jan 30, 2014

Contributor

This should have been puts "#{accept_eula_cmd} hdiutil attach #{passphrase_cmd} '#{dmg_file}'"``.
But I've proposed a better fix in #17.

end
not_if "hdiutil info #{passphrase_cmd} | grep -q 'image-path.*#{dmg_file}'"
end
Expand Down
2 changes: 1 addition & 1 deletion resources/package.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
attribute :app, :kind_of => String, :name_attribute => true
attribute :source, :kind_of => String, :default => nil
attribute :owner, :kind_of => String, :default => nil
attribute :destination, :kind_of => String, :default => '/Applications'
attribute :destination, :kind_of => String, :default => "/Applications"
attribute :checksum, :kind_of => String, :default => nil
attribute :volumes_dir, :kind_of => String, :default => nil
attribute :dmg_name, :kind_of => String, :default => nil
Expand Down

1 comment on commit 279321b

@mmannerm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on the providers/package.rb is breaking the functionality of the cookbook, and it no longer can install applications as it will never actually attach the .DMG file, just output a command that could be used to do it. I presume this was a local change for debugging purposes that slipped past. It should be reverted.

Please sign in to comment.