Skip to content
This repository has been archived by the owner on Apr 7, 2018. It is now read-only.

[COOK-4285] Accept long EULAs #17

Closed
wants to merge 1 commit into from

Conversation

jeroenj
Copy link
Contributor

@jeroenj jeroenj commented Jan 30, 2014

By setting PAGER to true it bypasses the EULA to be shown.
So user interaction is no longer required for dmg's with a long EULA.

This is a fix for COOK-4285 which actually never was fixed because of a faulty merge.

@jeroenj
Copy link
Contributor Author

jeroenj commented Jan 30, 2014

This might actually be COOK-4285. I noticed too late that you can't reopen issues.

@btm
Copy link

btm commented Jan 30, 2014

Thanks @jeroenj. I've converted COOK-4285 to an bug and updated links to it. It doesn't look like you've signed a CLA yet, could you please do so and then set COOK-4285 to 'Fix Provided' after it's processed?

https://wiki.opscode.com/display/chef/How+to+Contribute

By setting PAGER to true it bypasses the EULA to be shown.
So user interaction is no longer required for dmg's with a
long EULA.
@bjoernalbers
Copy link

@jeroenj Hey, nice and simple fix! Thanks

@jeroenj
Copy link
Contributor Author

jeroenj commented Feb 5, 2014

@btm I've signed the CLA last week but I'm still waiting for confirmation. Is it normal that this takes some time to be completed?

@jeroenj
Copy link
Contributor Author

jeroenj commented Feb 25, 2014

@someara it looks like something went wrong. The commits are not on master (version bump and changelog) but are only visible under the v2.2.0j tag.

Anyway, thanks for merging + relasing. :)

@Sauraus
Copy link
Contributor

Sauraus commented May 7, 2014

Why is this pull request still pending when the code is merged?

@someara
Copy link
Contributor

someara commented May 7, 2014

Human error. There's still a lot of manual process around COOK, partly because of CLA checking. It prevents us from "just clicking the green button". This will be eased with the move to Supermarket.

Closing.

@someara someara closed this May 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants