Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 34: Invalid include. #40

Merged
merged 1 commit into from
Dec 2, 2012

Conversation

leifmadsen
Copy link

Resolves issue 34 by not directly including the MiniTest::Assertions module. Rather,
we extend the usage of MiniTest::Assertions.

Resolves issue 34 by not directly including the MiniTest::Assertions module. Rather,
we extend the usage of MiniTest::Assertions.
@leifmadsen
Copy link
Author

Tested successfully.

Results with version 0.6.3:

Finished tests in 18.500030s, 0.3243 tests/s, 0.3784 assertions/s.


  1) Error:
test_0002_ensures_ssh_config_file_exists_with_correct_permissions(recipe::testing::default::files):
ArgumentError: wrong number of arguments (2 for 1)
    /var/chef/minitest/testing/default_test.rb:15:in `test_0002_ensures_ssh_config_file_exists_with_correct_permissions'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:226:in `run_report_unsafe'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:214:in `run_report_safely'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:93:in `run_report_handlers'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:92:in `each'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:92:in `run_report_handlers'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:103
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:110:in `call'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:110:in `run_completed_successfully'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:109:in `each'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:109:in `run_completed_successfully'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:426:in `do_run'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:176:in `run'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application/solo.rb:230:in `run_application'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application/solo.rb:218:in `loop'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application/solo.rb:218:in `run_application'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application.rb:70:in `run'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/chef-solo:25
    /usr/bin/chef-solo:19:in `load'
    /usr/bin/chef-solo:19

Results with this pull request:

Finished tests in 4.222982s, 1.4208 tests/s, 1.6576 assertions/s.


  1) Failure:
test_0002_ensures_ssh_config_file_exists_with_correct_permissions(recipe::testing::default::files) [/usr/lib/ruby/gems/1.8/gems/minitest-chef-handler-0.6.4/lib/minitest-chef-handler/resources.rb:41]:
The file does not have the expected owner.
Expected: "rot"
  Actual: "root"

@leifmadsen
Copy link
Author

@acrmp if you don't mind, please review, but this change is basically exactly as you suggested.

@calavera Issue 34 is now resolved with this pull request. I also updated the History and gemspec file so as to avoid any warnings during gem build.

@calavera
Copy link
Contributor

calavera commented Dec 2, 2012

well done, sir!

I'm merging the commit and releasing the gem right away.

@leifmadsen, @acrmp I'm aslo going to give you push privileges so you can commit changes directly. I encourage you to still open pull requests to continue having awesome conversations like the one to fix this issue.

Cheers

calavera pushed a commit that referenced this pull request Dec 2, 2012
Fixes issue #34: Invalid include.
@calavera calavera merged commit c7f613b into chef-boneyard:master Dec 2, 2012
@acrmp
Copy link
Contributor

acrmp commented Dec 3, 2012

Excellent. Thanks guys!

@leifmadsen
Copy link
Author

Indeed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants