Updated ruby-wmi to wmi-lite #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| if RUBY_PLATFORM =~ /mswin|mingw32|windows/ | |||
| require 'win32/registry' | |||
| require 'ruby-wmi' | |||
| require 'wmi-lite' | |||
There was a problem hiding this comment.
So this is good for an emergency fix, but will break if you're not running Chef 11.14. I think the right thing here is to use chef_gem to bring in the wmi-lite gem and then move the require to the right place.
|
Thanks @pieter-lazzaro. I've tested this and made some improvements in #101, closing this PR in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the ruby way to do things but changes seem to work.