You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
you should be able to click Add Users, try to add some users, then get a 403 error
Expected behavior
If a logged-in user is allowed to see a team and its users but is not allowed to manage team membership, they will not see the Add Users button on the team details page.
Design Details
hide the add users button if they don't have permission to add users to a team
if they happen to navigate to the add users page of a team, display this message on the page: It looks like you don't have permission to add users to this team. Reach out to your administrator or contact Chef Support for help. with Chef Support being an open in new tab link to our support page
Visual Design of Message
this or similar, feel free to use other properties to do the same thing
TBD if we also want to make some changes to the team-add-users modal in the case that someone without permissions navigated directly to https://a2-dev.test/settings/teams/admins/add-users. That would require some UX design from @susanev.
The text was updated successfully, but these errors were encountered:
* automate-ui: misc small changes
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* automate-ui/user-table: expose {get,create}PermissionsPaths, use in team-details
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* automate-ui/team-add-users: add no-access blank page
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* Full page render
Leverage the existing full-page rendering.
1. Setting the confirm button text to empty suppresses the lower buttons.
2. Use the same close handler to return to team details on exit.
3. A bit of a kludge: using the `heading` attribute to trigger the full page settings.
Signed-off-by: michael sorens <msorens@chef.io>
* automate-ui/authorized.component: remove overrideVisible
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* teams.proto: fix and amend example payloads
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* teams.proto: fix and amend example payloads [regen]
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* automate-ui/team-details: update specs
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* Add line breaks for consistency and clarity
Signed-off-by: michael sorens <msorens@chef.io>
* Unit test fixes identified by wallaby
It is occasionally "more correct" than the standard test runner
Signed-off-by: michael sorens <msorens@chef.io>
* Delete those defamatory falsehoods
Signed-off-by: michael sorens <msorens@chef.io>
* user-table: guard "add some users to get started"
The message to be shown when the user cannot add users is TBD.
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* user-table: change "no create perms" message
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* project-details: remove whitespace
Signed-off-by: Stephan Renatus <srenatus@chef.io>
* Make app-user-table ignorant of its consumers
Let the body of the `<app-user-table>` provide the text
of a "no-users-present-and-no-permissions-to-add-them" message.
Signed-off-by: michael sorens <msorens@chef.io>
Co-authored-by: michael sorens <msorens@chef.io>
Describe the bug
Right now there is no mechanism for hiding the
![Screen Shot 2020-01-30 at 9 47 00 AM](https://user-images.githubusercontent.com/21015366/73475679-ad72ae80-4345-11ea-8f7b-27d53e5e6838.png)
Add Users
button on the team-details page when the logged-in user has no permissions.This will require refactoring the user-table a bit. Right now we're passing
overridePermissions
input to the table on team-details. This was because at the time we did not have parameterized introspection. Now we do! So let's fix this.To Reproduce
test
Add Users
, try to add some users, then get a 403 errorExpected behavior
If a logged-in user is allowed to see a team and its users but is not allowed to manage team membership, they will not see the
Add Users
button on the team details page.Design Details
Visual Design of Message
this or similar, feel free to use other properties to do the same thing
TBD if we also want to make some changes to the team-add-users modal in the case that someone without permissions navigated directly to https://a2-dev.test/settings/teams/admins/add-users. That would require some UX design from @susanev.The text was updated successfully, but these errors were encountered: