#2762 guard add users button on team details view #3736

srenatus · 2020-05-19T14:33:44Z

🔩 Description: What code changed, and why?

Before, the Add Users button on the team details page has always been shown.

With this change, it will only be shown of the user has got sufficient privileges to actually do that.

Definition of done

hide the add users button if they don't have permission to add users to a team
if they happen to navigate to the add users page of a team, display this message on the page: It looks like you don't have permission to add users to this team. Reach out to your administrator or contact Chef Support for help. with Chef Support being an open in new tab link to our support page
changed/added tests pass

⛓️ Related Resources

#2762

👟 How to Build and Test the Change

rebuild automate-ui in your preferred way
sign in as admin, go to a team's details:

create a user and the policy mentioned in Guard Add Users buttons on team details page #2762, sign in as that user, go to the team's details page again, find the button gone:

as test user, navigate to https://a2-dev.test/settings/teams/editors/add-users, notice:

components/automate-ui/src/app/modules/user/user-table/user-table.component.spec.ts

srenatus · 2020-05-19T15:08:23Z

⚠️ the "no access" page is wrong, there should not be a heading and buttons.

srenatus · 2020-05-19T15:11:48Z

I've tried something... but now the close button (top right) is gone:

I suppose I could use some help here 😅

msorens · 2020-05-20T03:03:47Z

There are several ways to resolve your "no permissions" page issue. I have pushed a commit with what is probably the simplest approach.

components/automate-ui/src/app/modules/user/user-table/user-table.component.html

components/automate-ui/src/app/modules/team/team-add-users/team-add-users.component.ts

Signed-off-by: Stephan Renatus <srenatus@chef.io>

…eam-details Signed-off-by: Stephan Renatus <srenatus@chef.io>

Signed-off-by: Stephan Renatus <srenatus@chef.io>

Leverage the existing full-page rendering. 1. Setting the confirm button text to empty suppresses the lower buttons. 2. Use the same close handler to return to team details on exit. 3. A bit of a kludge: using the `heading` attribute to trigger the full page settings. Signed-off-by: michael sorens <msorens@chef.io>

Signed-off-by: Stephan Renatus <srenatus@chef.io>

srenatus · 2020-05-20T09:11:55Z

@msorens thanks again -- I've updated the preamble, this should be good to go now.

Signed-off-by: Stephan Renatus <srenatus@chef.io>

srenatus · 2020-05-20T09:21:16Z

✔️ Verified "add users" request payload (no unknown fields sent) and updated the API docs example payloads.

Signed-off-by: Stephan Renatus <srenatus@chef.io>

susanev

works great, thank you!!

components/automate-gateway/api/iam/v2/request/teams.proto

bcmdarroch · 2020-05-20T23:57:16Z

components/automate-ui/src/app/modules/user/user-table/user-table.component.html

@@ -1,11 +1,11 @@
-<app-authorized [allOf]="getPermissionsPath" [overrideVisible]="overridePermissionsCheck">
+<app-authorized [allOf]="getPermissionsPath">
  <ng-container *ngIf="showEmptyMessage">
    <div class="empty-state">
      <p>Add some users to get started!</p>


I noticed I still see this message when I'm logged in as the test user and I navigate to a team without any users

nice catch, we should leverage the similar msg we display on projects. ill add that here later tonight.

ℹ️ I'm looking into this now (Tuesday morning)

❓ I'm not sure I see what "similar msg" you've been referring to, @susanev.

When browsing a project's details as the test user, I find this, no message at all:

💡 You've meant this one:

I'll draft a similar message here that we can discuss later :)

the messages look good to me, thank you everyone for the assists!!

@msorens good catches! Let's tackle those separately, please. ;)

[...] but for the purposes of this PR we might want to address why the Users list is blank and is not showing the message (with or without my commit).

👍 I'll look into it.

@msorens can't reproduce. I've created a policy giving my user ALLOW on *, and DENY on iam:users:create, and see this:

@sr You exercised a different test case than the one I specified:

...when logged in as a user having no permissions then navigating directly to each page

(No strong preference whether that gets fixed in this PR, though.)

bcmdarroch

Looks good, although as the test user, I noticed one weird behavior when I was on a team page that did not already have users. (see comment for screenshot)

Signed-off-by: michael sorens <msorens@chef.io>

It is occasionally "more correct" than the standard test runner Signed-off-by: michael sorens <msorens@chef.io>

Signed-off-by: michael sorens <msorens@chef.io>

msorens

Pushed a few minor commits, including "fixes" for unit tests caught by wallaby that were not noticed by the regular test runner.
Also thought I found an odd bug. I was examining the rendered permissions in <app-authorized> for the two paths to get to the user table. Notice that the first one, for admins team, correctly shows a parameterized call BUT truncates the team id to "ad" in the <app-authorized> element. Turns out there is no bug in our code--rather it is a "bug" in Chrome DevTools: it truncates all attributes to 30 characters (not just on <app-authorized>) !!

The message to be shown when the user cannot add users is TBD. Signed-off-by: Stephan Renatus <srenatus@chef.io>

Signed-off-by: Stephan Renatus <srenatus@chef.io>

Let the body of the `<app-user-table>` provide the text of a "no-users-present-and-no-permissions-to-add-them" message. Signed-off-by: michael sorens <msorens@chef.io>

srenatus added WIP automate-ui auth-team anything that needs to be on the auth team board labels May 19, 2020

srenatus self-assigned this May 19, 2020

srenatus commented May 19, 2020

View reviewed changes

components/automate-ui/src/app/modules/user/user-table/user-table.component.spec.ts Outdated Show resolved Hide resolved

srenatus commented May 19, 2020

View reviewed changes

components/automate-ui/src/app/modules/user/user-table/user-table.component.spec.ts Outdated Show resolved Hide resolved

srenatus force-pushed the sr/issue-2762/guard-add-users-button-on-team-details-view branch 2 times, most recently from 5732098 to 7d18381 Compare May 19, 2020 15:04

srenatus marked this pull request as ready for review May 19, 2020 15:07

srenatus force-pushed the sr/issue-2762/guard-add-users-button-on-team-details-view branch from 7d18381 to 5c71b3d Compare May 19, 2020 15:10

msorens reviewed May 20, 2020

View reviewed changes

components/automate-ui/src/app/modules/user/user-table/user-table.component.html Show resolved Hide resolved

srenatus commented May 20, 2020

View reviewed changes

components/automate-ui/src/app/modules/team/team-add-users/team-add-users.component.ts Show resolved Hide resolved

automate-ui: misc small changes

84fcafa

Signed-off-by: Stephan Renatus <srenatus@chef.io>

srenatus force-pushed the sr/issue-2762/guard-add-users-button-on-team-details-view branch from 6835196 to 491bdd7 Compare May 20, 2020 09:03

srenatus and others added 4 commits May 20, 2020 11:07

automate-ui/user-table: expose {get,create}PermissionsPaths, use in t…

e90e82f

…eam-details Signed-off-by: Stephan Renatus <srenatus@chef.io>

automate-ui/team-add-users: add no-access blank page

014947a

Signed-off-by: Stephan Renatus <srenatus@chef.io>

automate-ui/authorized.component: remove overrideVisible

0cd1e4a

Signed-off-by: Stephan Renatus <srenatus@chef.io>

srenatus force-pushed the sr/issue-2762/guard-add-users-button-on-team-details-view branch from 491bdd7 to 0cd1e4a Compare May 20, 2020 09:08

srenatus removed the WIP label May 20, 2020

srenatus added 2 commits May 20, 2020 11:18

teams.proto: fix and amend example payloads

ee6489d

Signed-off-by: Stephan Renatus <srenatus@chef.io>

teams.proto: fix and amend example payloads [regen]

82e0442

Signed-off-by: Stephan Renatus <srenatus@chef.io>

automate-ui/team-details: update specs

125c93c

Signed-off-by: Stephan Renatus <srenatus@chef.io>

susanev added the ui label May 20, 2020

susanev approved these changes May 20, 2020

View reviewed changes

bcmdarroch reviewed May 20, 2020

View reviewed changes

components/automate-gateway/api/iam/v2/request/teams.proto Show resolved Hide resolved

bcmdarroch reviewed May 20, 2020

View reviewed changes

bcmdarroch approved these changes May 20, 2020

View reviewed changes

msorens added 3 commits May 20, 2020 20:12

Add line breaks for consistency and clarity

caf3ca7

Signed-off-by: michael sorens <msorens@chef.io>

Unit test fixes identified by wallaby

561d4fb

It is occasionally "more correct" than the standard test runner Signed-off-by: michael sorens <msorens@chef.io>

Delete those defamatory falsehoods

c6f4112

Signed-off-by: michael sorens <msorens@chef.io>

msorens approved these changes May 21, 2020

View reviewed changes

srenatus and others added 4 commits May 26, 2020 10:03

user-table: guard "add some users to get started"

8565307

The message to be shown when the user cannot add users is TBD. Signed-off-by: Stephan Renatus <srenatus@chef.io>

user-table: change "no create perms" message

390d438

Signed-off-by: Stephan Renatus <srenatus@chef.io>

project-details: remove whitespace

53e7c19

Signed-off-by: Stephan Renatus <srenatus@chef.io>

Make app-user-table ignorant of its consumers

db68dff

Let the body of the `<app-user-table>` provide the text of a "no-users-present-and-no-permissions-to-add-them" message. Signed-off-by: michael sorens <msorens@chef.io>

susanev mentioned this pull request May 28, 2020

hide available profiles page when desktop flag is used #3749

Closed

srenatus merged commit 22e5d7d into master May 29, 2020

chef-expeditor bot deleted the sr/issue-2762/guard-add-users-button-on-team-details-view branch May 29, 2020 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2762 guard add users button on team details view #3736

#2762 guard add users button on team details view #3736

srenatus commented May 19, 2020 •

edited

Loading

srenatus commented May 19, 2020

srenatus commented May 19, 2020

msorens commented May 20, 2020

srenatus commented May 20, 2020

srenatus commented May 20, 2020

susanev left a comment

bcmdarroch May 20, 2020

susanev May 20, 2020

srenatus May 26, 2020

srenatus May 26, 2020

srenatus May 26, 2020

susanev May 27, 2020

srenatus May 27, 2020

srenatus May 27, 2020

srenatus May 27, 2020

msorens May 28, 2020 •

edited

Loading

bcmdarroch left a comment

msorens left a comment •

edited

Loading

#2762 guard add users button on team details view #3736

#2762 guard add users button on team details view #3736

Conversation

srenatus commented May 19, 2020 • edited Loading

🔩 Description: What code changed, and why?

Definition of done

⛓️ Related Resources

👟 How to Build and Test the Change

srenatus commented May 19, 2020

srenatus commented May 19, 2020

msorens commented May 20, 2020

srenatus commented May 20, 2020

srenatus commented May 20, 2020

susanev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msorens May 28, 2020 • edited Loading

Choose a reason for hiding this comment

bcmdarroch left a comment

Choose a reason for hiding this comment

msorens left a comment • edited Loading

Choose a reason for hiding this comment

srenatus commented May 19, 2020 •

edited

Loading

msorens May 28, 2020 •

edited

Loading

msorens left a comment •

edited

Loading