Add types for animation in policy-add-members #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seajamied <jdegnan@chef.io>
msorens
approved these changes
Mar 23, 2020
|
FYI: To see the "before" situation--where this actually throws a compile error--you need to pull in this commit: |
msorens
pushed a commit
that referenced
this pull request
Mar 25, 2020
Signed-off-by: seajamied <jdegnan@chef.io>
msorens
pushed a commit
that referenced
this pull request
Mar 27, 2020
Signed-off-by: seajamied <jdegnan@chef.io>
msorens
pushed a commit
that referenced
this pull request
Mar 27, 2020
Signed-off-by: seajamied <jdegnan@chef.io>
msorens
added a commit
that referenced
this pull request
Mar 31, 2020
* Turn on template checking
Signed-off-by: michael sorens <msorens@chef.io>
* Fix mismatched function signature
error TS2554: Expected 0 arguments, but got 1
<input chefInput formControlName="newPassword" type="password" (keyup)="handlePasswordInput($event)" />
Signed-off-by: michael sorens <msorens@chef.io>
* Fix incompatible types
error TS2367: This condition will always return 'false' since the types 'CredentialTypes' and 'string' have no overlap.
<ng-container *ngIf="credential.type === 'ssh'">
Signed-off-by: michael sorens <msorens@chef.io>
* Cast AbstractControl to FormGroup
error TS2339: Property 'controls' does not exist on type 'AbstractControl'.
<div class="field" *ngIf="form.controls['end'].controls['include'].value">
Signed-off-by: michael sorens <msorens@chef.io>
* Add missing trackBy function
error TS2339: Property 'trackBy' does not exist on type 'SearchBarFilterBarComponent'.
<span *ngFor="let filter of filters; index as i; trackBy: trackBy;">
Signed-off-by: michael sorens <msorens@chef.io>
* Change symbol used in template to public
error TS2341: Property 'selectedStatus$' is private and only accessible within class 'ServiceGroupsComponent'.
<h3>None of the service groups returned {{ selectedStatus$ | async }}</h3>
Signed-off-by: michael sorens <msorens@chef.io>
* Accept Date type in datetime pipe
Handful of these errors due to feeding in a data type that was not present:
error TS2345: Argument of type 'Date' is not assignable to parameter of type 'string | Moment'.
Run succeeded {{ nodeRun.endTime | datetime: RFC2822 }}
Signed-off-by: michael sorens <msorens@chef.io>
* Remove browser warning
This browser console warning occurs on DataFeed page and Notifications page:
core.js:12557 Can't bind to 'contrasting-background' since it isn't a known property of 'chef-page-header'.
Signed-off-by: michael sorens <msorens@chef.io>
* Correct invalid expression
error TS2365: Operator '>' cannot be applied to types 'boolean' and 'number'.
50 <li *ngIf="inputText !== '' && delayForNoSuggestions && !filterValues.length > 0" class="no-category-items">
Signed-off-by: michael sorens <msorens@chef.io>
* Add types for animation in policy-add-members (#3180)
Signed-off-by: seajamied <jdegnan@chef.io>
* Event feed guitar strings template error
The incorrect type of parameter was being passed to the zoombutton.
Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
* Jamie/angular 9 followup fixes 2 (#3189)
* Fix status type on reporting component
Signed-off-by: seajamied <jdegnan@chef.io>
* Add types to reporting summary
Signed-off-by: seajamied <jdegnan@chef.io>
* Add disconnected group to initial model and type for disconnected services
Signed-off-by: seajamied <jdegnan@chef.io>
* Add stronger typing to report data service and reporting component
Signed-off-by: seajamied <jdegnan@chef.io>
* Inprove import and add more strong typing
Signed-off-by: seajamied <jdegnan@chef.io>
* Follow-on unit test fixes
Signed-off-by: michael sorens <msorens@chef.io>
* Fix failing job-form e2e specs
Signed-off-by: Scott Christopherson <scott@chef.io>
Co-authored-by: Jamie D <jamie.degnan@gmail.com>
Co-authored-by: Lance Finfrock <lfinfrock@chef.io>
Co-authored-by: Scott Christopherson <scott@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
This branch adds a type description for the animation changes in the add-members component.
⛓️ Related Resources
👍 Definition of Done
Errors showing here related to policy-add-members.component are gone
👟 How to Build and Test the Change
build components/automate-ui-devproxy
make serve
✅ Checklist
📷 Screenshots, if applicable