-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable backing up to Google Cloud Storage #3609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaym
reviewed
Jun 2, 2020
jaym
reviewed
Jun 2, 2020
jaym
reviewed
Jun 3, 2020
c6f5e86
to
a9229a4
Compare
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
…n protobuf Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
Signed-off-by: Jay Mundrawala <jmundrawala@chef.io>
jaym
reviewed
Jun 16, 2020
jaym
reviewed
Jun 16, 2020
jaym
reviewed
Jun 16, 2020
jaym
reviewed
Jun 16, 2020
jaym
reviewed
Jun 16, 2020
jaym
reviewed
Jun 16, 2020
yzl
reviewed
Jun 18, 2020
yzl
reviewed
Jun 18, 2020
jaym
reviewed
Jun 22, 2020
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Rios <mskdenigma@gmail.com>
jaym
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work here. Looks good
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
I am adding support for backing up into Google Cloud Storage buckets. Currently only local filesystem and S3 are supported which is not ideal for customers using external elasticsearch where mounting the same filesystem between hosts may be difficult.
⛓️ Related Resources
👍 Definition of Done
I should be able to add the following config
and after patching my config backups including will go into a GCS bucket
👟 How to Build and Test the Change
✅ Checklist
📷 Screenshots, if applicable