adding GCS Backup Documentation #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bright <danielcbright@gmail.com>
|
LGTM! |
mjingle
reviewed
Aug 5, 2020
mjingle
reviewed
Aug 5, 2020
mjingle
reviewed
Aug 5, 2020
| # protocol = "https" | ||
| ``` | ||
|
|
||
| ##### Backup to GCS |
There was a problem hiding this comment.
@danielcbright Is this section the equivalent of "Backup Externally-Deployed Elasticsearch to GCS"? or is this not for externally-deployed Elasticsearch?
There was a problem hiding this comment.
also ok with this, oops, wrong comment on wrong part!
Yes, looking back at it now, it doesn't really flow very well, but yes, this is specific to externally deployed ES
added 2 commits
August 7, 2020 10:49
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
|
@danielcbright can you rebase this on master? |
…ackup_docs Signed-off-by: Daniel Bright <danielcbright@gmail.com>
…nto gcs_backup_docs
|
Looks like the build is finding "possible credentials" Is there any way around this? |
Signed-off-by: Daniel Bright <danielcbright@gmail.com>
|
@danielcbright yah you can add an exception for it, i think you and mary decided to go another way but let me know if you need to know how and ill ask in a2-team |
Signed-off-by: Daniel Bright <danielcbright@gmail.com>
mjingle
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Bright danielcbright@gmail.com
🔩 Description: What code changed, and why?
This is a PR to add documentation for the GCS Backup support that was added via PR #3609 thanks to the great work by @mskdenigma and @jaym .
⛓️ Related Resources
backup and external backup configurations and related documentation
👍 Definition of Done
Documentation is signed off by the appropriate teams
👟 How to Build and Test the Change
Testing is already done for the functionality of the GCS backups, this is just documentation
✅ Checklist
📷 Screenshots, if applicable