Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed words not wrapping when exceeding the max width #3767

Merged
merged 2 commits into from
May 22, 2020
Merged

Fixed words not wrapping when exceeding the max width #3767

merged 2 commits into from
May 22, 2020

Conversation

vinay033
Copy link
Collaborator

Signed-off-by: Vinay Sharma vsharma@chef.io

🔩 Description: What code changed, and why?

When users reduce the window width on the service group page, data that exceed the max-width of the text field becomes incomplete.
I have added some changes to fix this.

⛓️ Related Resources

#2150

👍 Definition of Done

I have added some CSS class for the right side bar and now its showing as expected.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

✅ Checklist

📷 Screenshots

  1. existing
    service-group

  2. after fix
    service-group-fix

@vinay033
fixed issue for exceeding the max width
5bc3fe6 
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@vinay033 vinay033 self-assigned this May 21, 2020
@susanev susanev requested a review from a team May 21, 2020 19:20
SEAjamieD
SEAjamieD approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

susanev
susanev reviewed May 21, 2020
View reviewed changes
components/automate-ui/src/app/page-components/services-sidebar/services-sidebar.component.html Outdated
<div class ="supervisor-line"><b>Supervisor:</b> {{ service.supervisor_id || "--"}}</div>
<div class ="site-line"><b>Site:</b> {{ service.site || "--"}}</div>
<div class ="fqdn-line"><chef-icon>storage</chef-icon> <p class="fqdn-data">{{ service.fqdn || "--"}}</p></div>
<div class ="supervisor-line"><b>Supervisor:</b> <p class="supervisor-data">{{ service.supervisor_id || "--"}}</p></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is not from you, but can you use strong tags here instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed to strong.

@vinay033
added review comment changes
759a243 
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@susanev susanev merged commit 1677062 into master May 22, 2020
@chef-expeditor chef-expeditor bot deleted the Vinay/service-group-word-wrap branch May 22, 2020 15:15
@sachin-msys sachin-msys mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susanev susanev susanev left review comments

@SEAjamieD SEAjamieD SEAjamieD approved these changes

Assignees

@vinay033 vinay033

Labels
automate-ui ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vinay033 @susanev @SEAjamieD