Add heading and help text to compliance reporting view #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Christopherson <scott@chef.io>
Signed-off-by: Scott Christopherson <scott@chef.io>
scottopherson
force-pushed
the
sc/compliance-heading
branch
from
a7f47cb
to
4d8a42f
Compare
susanev
approved these changes
Apr 11, 2019
stevendanna
approved these changes
Apr 12, 2019
alexpop
reviewed
Apr 12, 2019
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| <div class="container"> | |||
| <main> | |||
| <chef-page-header> | |||
| <chef-heading>Compliance Reporting</chef-heading> | |||
| <chef-subheading>Compliance reports describe the status of scanned infrastructure. Filtering by a profile, or a profile and one associated control, will enable deep filtering, which will also reflect on the status of the node.</chef-subheading> | |||
There was a problem hiding this comment.
What do you think about hyperlinking deep filtering to the docs page that will give more details about it:
There was a problem hiding this comment.
let's get this merged in to make sure we have it and then we can loop back around with the hyperlink afterwards
There was a problem hiding this comment.
Docs link would be: https://automate.chef.io/docs/compliance/#deep-filtering as the PR above merged a few minutes ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
Adds heading and help text to compliance reporting view. Also configures
chef-subheadingto have a max-width.