Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamie/4699 frontend update deps #4835

Merged
merged 36 commits into from
Mar 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
691bd47
Run npm update
Mar 17, 2021
425102e
ng update @ngrx/effects
Mar 17, 2021
4fabbf1
run ng update @angular-devkit/build-angular
Mar 17, 2021
97a6555
run ng update @nguniversal/express-engine
Mar 17, 2021
889cfcc
Manually patch deprecation for @effect
Mar 17, 2021
5518f3b
Updating @effect deprecation
Mar 17, 2021
7dc757b
More manual updating of effect to createEffect
Mar 17, 2021
d34197a
More manual updating effect to createEffect
Mar 17, 2021
5dfea0e
More manual updating effect to createEffect
Mar 17, 2021
2c155ed
More manual updating effect to createEffect
Mar 17, 2021
7df4c8d
More effect updates, One error needs resolving
Mar 17, 2021
9210df3
All effect to createEffect updates made with exception to one error.
Mar 17, 2021
d9dbf44
Resolve CUSTOM_ELEMENTS_SCHEMA errors
Mar 18, 2021
108ddd9
Fixed createEffect error.
Mar 18, 2021
b8b746c
New fix updated
Mar 18, 2021
019aca5
Bring angular packages up to 11.2.6
Mar 18, 2021
9338805
Update angular-devkit
Mar 18, 2021
1d85564
Update other angular packages to 11.2.5
Mar 18, 2021
446f921
Update @angular/cli to 11.2.5
Mar 18, 2021
7cd1a7b
Update zone.js to 0.11.4
Mar 18, 2021
c05f356
Update documentation
Mar 18, 2021
d5c13c5
Updated package jwt-decode -> errors
Mar 18, 2021
139d0b1
Update documentation
Mar 18, 2021
898dc8e
Revert deleteServicesById$ - error
Mar 18, 2021
63ccd7d
Update return signature to be an Observable
Mar 19, 2021
4a8ddb6
Update effects in rebased page
Mar 19, 2021
37e21fd
Fix some mockselector errors from the master rebase
Mar 19, 2021
2579c52
Revert misplaced Mock
Mar 19, 2021
c96e6ce
Remove returns from createEffect
Mar 22, 2021
a86a450
Updating syntax of createEffects to remove returns
Mar 22, 2021
607a2bf
More updating effect syntax
Mar 22, 2021
0c76ba0
More updating createEffects syntax
Mar 22, 2021
e09390d
Complete updates of createEffect syntax
Mar 22, 2021
a778338
Rebase and update incoming effects
Mar 22, 2021
9d82590
Fix merge conflicts
Mar 24, 2021
ed3b4a8
Weird left over merge issues resolved
Mar 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions components/automate-ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,21 +55,9 @@ Certain packages in package.json are constrained for the reasons detailed here.
At any future moment though, the reasons for constraint here could be invalidated, so this should be updated as needed when package.json is updated.
While it is problematic to document this information due to the maintenance burden, the value of having this in one place outweighs that burden.

### Packages @ngrx/* =10.1.0
### Package typescript: ^4.0.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice--thanks for keeping these docs current!


awaiting the release of ngrx 11. Until then, we will get incompatible peer dependencies if we try to update to latest.

### Package karma: ^5.1.1

"@angular-devkit/build-angular" has an incompatible peer dependency to Karma which requires ~5.1.0.

### Package typescript: ^4.0.5

"@angular-devkit/build-angular" has an incompatible peer dependency to typescript which requires ~4.0.0

### Package jwt-decode: ^2.2.0

Newer versions of jwt_decode introduce a new import format, which is breaking some of our testing.
Package "@angular-devkit/build-angular" has an incompatible peer dependency to "typescript" (requires "~4.0.0 || ~4.1.0")

### Package immutable: ^3.8.2

Expand All @@ -79,11 +67,6 @@ Reason: Later releases are release candidates; should only be using production-r

Per https://github.com/chef/automate/pull/1867, future versions have made a breaking change so it breaks our code base.

### Package zone.js: ^0.10.3

Per: https://www.npmjs.com/package/zone.js?activeTab=readme, Starting with v0.11.1, A breaking change is introduced for legacy browsers such as IE11. If we are no longer supporting IE 11, we are safe to upgrade, otherwise we can instead `import 'zone.js/dist/zone';`

There is a also an incompatible peer dependency with angular/core that will be cleared up in Angular 11.1.0 re: https://github.com/angular/angular/issues/39094#issuecomment-742227156

## Angular Module Architecture

Expand Down
Loading