Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased cypress test retry limit to 2 #5084

Merged
merged 1 commit into from
May 20, 2021

Conversation

vivek-yadav
Copy link
Collaborator

Signed-off-by: Vivek Yadav vivek.yadav@progress.com

🔩 Description: What code changed, and why?

As the cypress test in the pipeline was flaky.
This will ensure automatic retry 2 times before declaring the pipeline as failure.

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>
@netlify
Copy link

netlify bot commented May 19, 2021

Deploy Preview for chef-automate processing.

Building with commit 47cb05e

https://app.netlify.com/sites/chef-automate/deploys/60a52662336b230008662ef7

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vivek-yadav
Copy link
Collaborator Author

This still failed after multiple retries.... not sure if we should commit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants