Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Chef Environment Cookbooks constraints capitalisation #5089

Merged
merged 1 commit into from
May 27, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented May 21, 2021

Signed-off-by: Vinay Sharma vsharma@chef.io

πŸ”© Description: What code changed, and why?

Chef environment cookbook pins have the first letter of the cookbook automatically capitalized. The desired outcome is to have case processing on the cookbook names as created.

⛓️ Related Resources

#5079

πŸ‘ Definition of Done

I have added some minor changes to fix this.

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

navigate to `https://a2-dev.test/infrastructure/chef-servers`
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the -->  `infrastructure tab` from the top navigation bar then you can see the `Chef Infra Server`
If you have data then you can see the list of servers 
--> then click to any of the servers --> see the list of org's
--> click to any of org ---> you can see the multiple tabs --> default tab is cookbooks tab 
--> you can see the list of cookbooks ---> click on any cookbook
--> you can redirect to the cookbook details page where you can see the list of contraints.

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Screenshot 2021-05-21 at 5 47 37 PM

Signed-off-by: Vinay Sharma <vsharma@chef.io>
@netlify
Copy link

netlify bot commented May 21, 2021

Deploy Preview for chef-automate processing.

Building with commit a6f96a5

https://app.netlify.com/sites/chef-automate/deploys/60a7af8848a0a60008e965ee

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thanks @vinay033

Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@kalroy kalroy merged commit f793dd5 into master May 27, 2021
@kalroy kalroy deleted the Vinay/fixed_env_constraint_capitalization branch May 27, 2021 06:44
@kalroy kalroy added the bug πŸ› Something isn't working label Jun 4, 2021
tas50 added a commit that referenced this pull request Jun 8, 2021
This is the same fix as #5089, but
we also need to make sure that the attributes are not capitalized.

Signed-off-by: Tim Smith <tsmith@chef.io>
himanshi-chhabra pushed a commit that referenced this pull request Jun 14, 2021
This is the same fix as #5089, but
we also need to make sure that the attributes are not capitalized.

Signed-off-by: Tim Smith <tsmith@chef.io>
kalroy pushed a commit that referenced this pull request Jun 14, 2021
This is the same fix as #5089, but
we also need to make sure that the attributes are not capitalized.

Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants