Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capitalize the attributes in the environment details #5205

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 8, 2021

πŸ”© Description: What code changed, and why?

Attributes on the environment details page are now displayed in the correct case that came back from the server.

⛓️ Related Resources

#5204

πŸ‘ Definition of Done

It matches the data you'd see if you ran knife environment show foo

πŸ‘Ÿ How to Build and Test the Change

????

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jun 8, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: c05b5af

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60c725b76534e10007a154c9

@vinay033 vinay033 self-requested a review June 10, 2021 13:55
Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘πŸ»

This is the same fix as #5089, but
we also need to make sure that the attributes are not capitalized.

Signed-off-by: Tim Smith <tsmith@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy merged commit b3f3c12 into master Jun 14, 2021
@kalroy kalroy deleted the tas50/attributes branch June 14, 2021 18:37
@kalroy kalroy added bug πŸ› Something isn't working automate-ui labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants