Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI improvements #5276

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Added UI improvements #5276

merged 2 commits into from
Jun 23, 2021

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Jun 23, 2021

Signed-off-by: chaitali-mane cmane@progress.com

πŸ”© Description: What code changed, and why?

  • Infra Server object classes Removed from Environment tab no need to show user that data.
  • Aligned create Button is not vertically through all Infra chef servers tabs
  • Reduced the margin between search box and list in Data bag details tab
  • Removed border on Reset key button after button click in Client detail page only show hover effect
  • Added mouse hover styles on buttons in data bag details page and Environment tab, for expand collapse buttons
  • Disable feature on create, save button when they are in progress state to all tabs as not able to cancel request.

⛓️ Related Resources

#4995
#5000
#5001
#5014
#5017
#5023

πŸ‘ Definition of Done

  • Infra Server object classes Removed from Environment tab
  • Aligned create Button is not vertically through all Infra chef servers tabs
  • Reduced the margin between search box and list in Data bag details tab
  • Removed border on Reset key button after button click in Client detail page
  • Added mouse hover styles on buttons in data bag details page and Environment tab
  • Added Disable feature on create, save button when they are in progress state to all tabs

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data
https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Steps for tabs

Go To Infrastructure -> Chef Servers -> click server name-> click org name -> click on any tab
where you can check changes

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jun 23, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: a82288e

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60d30f6aae5df100079c1af2

Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good πŸ‘

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit eecaf6a into master Jun 23, 2021
@kalroy kalroy deleted the Chaitali/disable_buttons branch June 23, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants