Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription id in Azure-api #5291

Merged
merged 63 commits into from
Jun 28, 2021
Merged

Add subscription id in Azure-api #5291

merged 63 commits into from
Jun 28, 2021

Conversation

shaik80
Copy link
Member

@shaik80 shaik80 commented Jun 25, 2021

🔩 Description: What code changed, and why?

Need to add an input text box for subscription_id in settings->node integration->azure-api and have to make backend changes respectively

⛓️ Related Resources

#5252

👍 Definition of Done

  • Add Input text box in settings->node integration->azure->azure-api
  • Input text box for subscription_id will be shown in azure-api not in VM (screenshot is mentioned below)
  • Done backend changes in the following services (storing subscriptionId in secret service and retrieving them)
    • compliance
    • node manager

👟 How to Build and Test the Change

  • For UI
STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

  • Backend
    rebuild components/compliance-service
    rebuild components/nodemanager-service
  • test cases
    go test components/nodemanager-service/managers

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2021-06-17 at 5 32 57 PM

Screenshot 2021-06-17 at 5 33 11 PM

@netlify
Copy link

netlify bot commented Jun 25, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 2ac387a

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60d9836c0331c800077212fc

@shaik80 shaik80 self-assigned this Jun 25, 2021
Ubuntu and others added 26 commits June 27, 2021 18:58
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
shaik80 and others added 24 commits June 27, 2021 19:14
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: shaik80 <sh.mudassir98@gmail.com>
Signed-off-by: Shaik Mudassir <47217471+shaik80@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
39.7% 39.7% Duplication

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@kalroy kalroy merged commit 60becb6 into master Jun 28, 2021
@kalroy kalroy deleted the azure_intigration_demo branch June 28, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants