-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow addition of new node with selected node credentials #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 22ac141 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6181600420239c00087b9b70 |
shaik80
added
automate-ui
compliance scan jobs
This issue or pull request applies to the scan jobs part of Automate
WIP
labels
Sep 23, 2021
shaik80
changed the title
Allow addition of new node with selected node credentials
[WIP] Allow addition of new node with selected node credentials
Sep 23, 2021
shaik80
changed the title
[WIP] Allow addition of new node with selected node credentials
Allow addition of new node with selected node credentials
Oct 25, 2021
shaik80
force-pushed
the
shaik-5775/selected_node_credentials
branch
from
October 25, 2021 14:49
b74bab1
to
1b5b2d4
Compare
vivekshankar1
requested changes
Oct 27, 2021
...s/automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-add/nodes-add.component.ts
Show resolved
Hide resolved
...automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-edit/nodes-edit.component.ts
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-add/nodes-add.component.html
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-add/nodes-add.component.html
Outdated
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/selectbox/selectbox.component.html
Outdated
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/selectbox/selectbox.component.html
Outdated
Show resolved
Hide resolved
...s/automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-add/nodes-add.component.ts
Show resolved
Hide resolved
...tomate-ui/src/app/pages/+compliance/+scanner/containers/nodes-edit/nodes-edit.component.html
Outdated
Show resolved
Hide resolved
...tomate-ui/src/app/pages/+compliance/+scanner/containers/nodes-edit/nodes-edit.component.html
Outdated
Show resolved
Hide resolved
...tomate-ui/src/app/pages/+compliance/+scanner/containers/nodes-edit/nodes-edit.component.html
Show resolved
Hide resolved
...automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-add/nodes-add.component.scss
Show resolved
Hide resolved
...s/automate-ui/src/app/pages/+compliance/+scanner/containers/nodes-add/nodes-add.component.ts
Show resolved
Hide resolved
components/automate-ui/src/app/pages/+compliance/+scanner/scanner.module.ts
Show resolved
Hide resolved
...tomate-ui/src/app/pages/+compliance/+scanner/containers/nodes-edit/nodes-edit.component.scss
Show resolved
Hide resolved
...s/automate-ui/src/app/page-components/accordion/accordion-item/accordion-item.component.scss
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/selectbox/selectbox.component.ts
Outdated
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/selectbox/selectbox.component.ts
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/selectbox/selectbox.component.ts
Show resolved
Hide resolved
vivekshankar1
approved these changes
Nov 2, 2021
shivangi-singh1
approved these changes
Nov 2, 2021
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
shaik80
force-pushed
the
shaik-5775/selected_node_credentials
branch
from
November 2, 2021 15:57
d20706d
to
22ac141
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
vivek-yadav
added
the
Team: S.H.I.E.L.D.
This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
label
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
acceptance: verified
automate-ui
compliance scan jobs
This issue or pull request applies to the scan jobs part of Automate
Team: S.H.I.E.L.D.
This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shaik80 shaik.mudassir@progress.com
🔩 Description: What code changed, and why?
Created accordion, accordion-list(for multiple accordions), and select Box component to select node credential from the list
⛓️ Related Resources
#5775
👍 Definition of Done
Created accordion, accordion-list(for multiple accordions), and select Box component to select node credential from the list.
It should select multiple creds and move to your right side, make sure when you are paginating the next request it should avoid duplicate credentials which are already selected.
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Screen.Recording.2021-10-25.at.10.50.30.AM.mov