Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow addition of new node with selected node credentials #5788

Merged
merged 39 commits into from
Nov 2, 2021

Conversation

shaik80
Copy link
Member

@shaik80 shaik80 commented Sep 23, 2021

Signed-off-by: shaik80 shaik.mudassir@progress.com

🔩 Description: What code changed, and why?

Created accordion, accordion-list(for multiple accordions), and select Box component to select node credential from the list

⛓️ Related Resources

#5775

👍 Definition of Done

Created accordion, accordion-list(for multiple accordions), and select Box component to select node credential from the list.
It should select multiple creds and move to your right side, make sure when you are paginating the next request it should avoid duplicate credentials which are already selected.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screen.Recording.2021-10-25.at.10.50.30.AM.mov

@netlify
Copy link

netlify bot commented Sep 23, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 22ac141

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6181600420239c00087b9b70

@shaik80 shaik80 self-assigned this Sep 23, 2021
@shaik80 shaik80 added automate-ui compliance scan jobs This issue or pull request applies to the scan jobs part of Automate WIP labels Sep 23, 2021
@shaik80 shaik80 changed the title Allow addition of new node with selected node credentials [WIP] Allow addition of new node with selected node credentials Sep 23, 2021
@shaik80 shaik80 removed the WIP label Oct 25, 2021
@shaik80 shaik80 changed the title [WIP] Allow addition of new node with selected node credentials Allow addition of new node with selected node credentials Oct 25, 2021
@shaik80 shaik80 force-pushed the shaik-5775/selected_node_credentials branch from b74bab1 to 1b5b2d4 Compare October 25, 2021 14:49
shaik80 and others added 6 commits November 2, 2021 21:27
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
Signed-off-by: shaik80 <smudassi@progress.com>
@shaik80 shaik80 force-pushed the shaik-5775/selected_node_credentials branch from d20706d to 22ac141 Compare November 2, 2021 15:57
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vivek-yadav vivek-yadav merged commit 529baef into main Nov 2, 2021
@vivek-yadav vivek-yadav deleted the shaik-5775/selected_node_credentials branch November 2, 2021 16:46
@vivek-yadav vivek-yadav added the Team: S.H.I.E.L.D. This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories) label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified automate-ui compliance scan jobs This issue or pull request applies to the scan jobs part of Automate Team: S.H.I.E.L.D. This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants