Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI improvements #5819

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Added UI improvements #5819

merged 1 commit into from
Sep 29, 2021

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Sep 28, 2021

Signed-off-by: chaitali-mane cmane@progress.com

πŸ”© Description: What code changed, and why?

  • Need to add search bar validation in the Infra node tab
  • Need to update Infra node environment as changes
  • Need to remove text from add organization modal

⛓️ Related Resources

#5192
#5188
#5046

πŸ‘ Definition of Done

  • Added search bar validation in the Infra node tab
  • Update Infra node environment value as changes
  • Removed text from add organization modal

πŸ‘Ÿ How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab
  1. Steps for Nodes tab:
    Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on any org -> go to Nodes tab -> click on any node -> where you can see update environment will update the value
  2. Steps for Nodes tab:
    Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> go to Nodes tab -> search bar validation
  3. Steps for add org modal:
    Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> click on Add organization button

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: chaitali-mane <cmane@progress.com>
@chaitali-mane chaitali-mane self-assigned this Sep 28, 2021
@netlify
Copy link

netlify bot commented Sep 28, 2021

πŸ‘· Deploy Preview for chef-automate processing.

πŸ”¨ Explore the source changes: b1e0727

πŸ” Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6153248746b7490007aa0e5f

@chaitali-mane chaitali-mane added automate-infra-proxy automate-ui Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues ui labels Sep 28, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 9873ea7 into main Sep 29, 2021
@kalroy kalroy deleted the Chaitali/UI_improvements branch September 29, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified automate-infra-proxy automate-ui Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants