Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra server UI improvements #5837

Merged
merged 7 commits into from
Oct 7, 2021
Merged

Infra server UI improvements #5837

merged 7 commits into from
Oct 7, 2021

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented Oct 1, 2021

Signed-off-by: chaitali-mane cmane@progress.com

🔩 Description: What code changed, and why?

When the spinner loading, the user should not able to click add/ delete button.
The cookbook constraint window input appears to require x.y.z format, but this is not required for versions in a constraint. ~> 2.0 is entirely valid.

⛓️ Related Resources

#5190
#4992

👍 Definition of Done

Updated code for when the spinner loading, the user should not able to click add/ delete button.
The cookbook constraint window input appears to require x.y.z format, but this is not required for versions in a constraint. ~> 2.0 is entirely valid.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

Steps for Nodes tab:
Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on any org -> go to Nodes tab -> click on any node --. where you can see changes
Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on any org -> go to Environment tab -> click on create Environment button or Edit cookbook constraint

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@chaitali-mane chaitali-mane added ui automate-ui automate-infra-proxy Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels Oct 1, 2021
@chaitali-mane chaitali-mane self-assigned this Oct 1, 2021
@netlify
Copy link

netlify bot commented Oct 1, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 32f1bb9

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/615dae2ea8b81d0008a3ee04

Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me.

Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 64daf69 into main Oct 7, 2021
@kalroy kalroy deleted the Chaitali/ui_improvements branch October 7, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified automate-infra-proxy automate-ui Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants