Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the cacert for DST RootCA X3 #5844

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Remove the cacert for DST RootCA X3 #5844

merged 2 commits into from
Oct 5, 2021

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Oct 4, 2021

Signed-off-by: Kallol Roy karoy@progress.com

🔩 Description: What code changed, and why?

OpenSSL 1.0.2 does not by pass Lets encrypt old certificates which expired on 30th September 2021. This has caused many components in Automate to fail the build.

⛓️ Related Resources

#5847

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Oct 4, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: f585b73

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/615b2c563404f50008dbc2c8

@kalroy kalroy marked this pull request as draft October 4, 2021 10:16
@kalroy kalroy requested a review from mwrock October 4, 2021 13:12
@kalroy kalroy marked this pull request as ready for review October 4, 2021 14:21
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit b79b812 into main Oct 5, 2021
@kalroy kalroy deleted the kallol/workaround_ssl_fix branch October 5, 2021 09:39
vivek-yadav added a commit that referenced this pull request Oct 6, 2021
…id and generate report (#5792)

* removed subsctoption id

Signed-off-by: MadhviA <matroliy@progress.com>

* removed subsctoption id

Signed-off-by: MadhviA <matroliy@progress.com>

* removed custom typeError line

Signed-off-by: MadhviA <matroliy@progress.com>

* Revert "removed custom typeError line"

This reverts commit 34827f7.

* removed custom typeError line

Signed-off-by: MadhviA <matroliy@progress.com>

* Removed console.log

Signed-off-by: MadhviA <matroliy@progress.com>

* merging conflicts from main

Signed-off-by: MadhviA <matroliy@progress.com>

* Fix for Masking User Cred in PG DB URI (#5845)

* masked DB String in logs

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* mask PG cred in URI

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* info string change

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* move files to data-feed-service

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* added postgresql: in regex

Signed-off-by: Vivek Yadav <vivek.yadav@progress.com>

* fix: a2ha habitat cert issue (#5834)

Signed-off-by: meet58 <mgadhiya@msystechnologies.com>

* Adding info and ssh commands to automate-cli (#5716)

* Adding info and ssh commands

Signed-off-by: FaizanSRE <ffulara@msystechnologies.com>

* Did gofmt of new go files

Signed-off-by: FaizanSRE <ffulara@msystechnologies.com>

* Addind help for info command

Signed-off-by: FaizanSRE <ffulara@msystechnologies.com>

* removed comments

* Apply suggestions from code review

Co-authored-by: Kallol Roy <karoy@progress.com>
Signed-off-by: FaizanSRE <ffulara@msystechnologies.com>

Co-authored-by: Kallol Roy <karoy@progress.com>

* Executed '.expeditor/generate-automate-cli-docs.sh'

Obvious fix; these changes are the result of automation not creative thinking.

* Tail logs, Needed to show log in run-time for deploy and provision (#5833)

* Signed-off-by: jay vikram sharma <jsharma@progress.com>
tail logs from file in main thread, and pgleaderchk in product.meta

* Signed-off-by: jay vikram sharma <jsharma@progress.com>
changing log messages

* Signed-off-by: jay vikram sharma <jsharma@progress.com>
printing error instead of return for tailFile

* Signed-off-by: jay vikram sharma <jsharma@progress.com>
removing un-used dependencies

* Signed-off-by: jay vikram sharma <jsharma@progress.com>
removing un-used dependencies

* Signed-off-by: jay vikram sharma <jsharma@progress.com>
we had missed one changes regarding fetching package name from current manifest, we added in this PR

Co-authored-by: jay vikram sharma <jsharma@progress.com>

* Remove the cacert for DST RootCA X3 (#5844)

* Remove the cacert for DST RootCA X3

Signed-off-by: Kallol Roy <karoy@progress.com>

* Exclude the cacert file from check

Signed-off-by: Kallol Roy <karoy@progress.com>

* indentation changes

Signed-off-by: MadhviA <matroliy@progress.com>

* removed subsctoption id

Signed-off-by: MadhviA <matroliy@progress.com>

* removed subsctoption id

Signed-off-by: MadhviA <matroliy@progress.com>

* removed custom typeError line

Signed-off-by: MadhviA <matroliy@progress.com>

* Revert "removed custom typeError line"

This reverts commit 34827f7.

* removed custom typeError line

Signed-off-by: MadhviA <matroliy@progress.com>

* Removed console.log

Signed-off-by: MadhviA <matroliy@progress.com>

* merging conflicts from main

Signed-off-by: MadhviA <matroliy@progress.com>

* indentation changes

Signed-off-by: MadhviA <matroliy@progress.com>

* changed cypress indentation

Signed-off-by: MadhviA <matroliy@progress.com>

Co-authored-by: MadhviA <matroliy@progress.com>
Co-authored-by: Vivek Yadav <vivek.yadav@progress.com>
Co-authored-by: meet.gadhiya <60958104+meet58@users.noreply.github.com>
Co-authored-by: Faizan <60912283+FaizanSRE@users.noreply.github.com>
Co-authored-by: Kallol Roy <karoy@progress.com>
Co-authored-by: Chef Expeditor <chef-ci@chef.io>
Co-authored-by: Jay Vikram Sharma <36661596+jayvikramsharma1@users.noreply.github.com>
Co-authored-by: jay vikram sharma <jsharma@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants