Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin erlang version to v21.3 #6638

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Pin erlang version to v21.3 #6638

merged 1 commit into from
Feb 3, 2022

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Jan 28, 2022 •
edited
Loading

Signed-off-by: Kallol Roy karoy@progress.com

🔩 Description: What code changed, and why?

Notification service is not able to connect to external services like Slack and Webhook.
This is because erlang version is bumped to v23.2 from earlier v21.0
This PR is pinning the version to v21.3

⛓️ Related Resources

#6634
#6597

👍 Definition of Done

  • Test the changes by testing with other external endpoints

👟 How to Build and Test the Change

  • rebuild components/notification-servce
  • start_all_services
  • Open automate ui and navigate to settings tab
  • Open Notifications
  • Test webhook by hitting https://enq65ijsovsf8.x.pipedream.net
  • Test slack by hitting https://hooks.slack.com/services/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

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@kalroy
Pin erlang version to v21.3
91f1ca9 
Signed-off-by: Kallol Roy <karoy@progress.com>
@netlify
Copy link

netlify bot commented Jan 28, 2022

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 91f1ca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61f436a8c6cc9b00073a95a5

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

vivekshankar1
vivekshankar1 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working properly now. Notifications are being sent to incident app and event creation app from notification service. Thanks @kalroy

@kalroy kalroy merged commit 2593038 into main Feb 3, 2022
@kalroy kalroy deleted the fix_notification_failure branch February 3, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-yadav vivek-yadav vivek-yadav approved these changes

@vivekshankar1 vivekshankar1 vivekshankar1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalroy @vivek-yadav @vivekshankar1