-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHIELD-71 SHIELD-78 Modified source of id_token. #7145
Merged
vivek-yadav
merged 22 commits into
main
from
SHIELD-64-security-fixes-of-session-cookie
Jun 29, 2022
Merged
SHIELD-71 SHIELD-78 Modified source of id_token. #7145
vivek-yadav
merged 22 commits into
main
from
SHIELD-64-security-fixes-of-session-cookie
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
atultherajput
requested review from
vivek-yadav,
vivekshankar1,
iamazzeez,
shaik80 and
shivangi-singh1
June 8, 2022 09:59
vivekshankar1
approved these changes
Jun 9, 2022
atultherajput
added
the
Team: S.H.I.E.L.D.
This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
label
Jun 9, 2022
atultherajput
force-pushed
the
SHIELD-64-security-fixes-of-session-cookie
branch
from
June 10, 2022 09:23
43a53bc
to
9c0f41f
Compare
shaik80
approved these changes
Jun 14, 2022
iamazzeez
approved these changes
Jun 14, 2022
shivangi-singh1
approved these changes
Jun 15, 2022
atultherajput
requested review from
shaik80,
vivekshankar1,
shivangi-singh1 and
iamazzeez
June 16, 2022 05:56
atultherajput
changed the title
SHIELD-64 Added Secure in id_token cookie.
SHIELD-64 Modified source of id_token.
Jun 16, 2022
atultherajput
changed the title
SHIELD-64 Modified source of id_token.
SHIELD-71 Modified source of id_token.
Jun 16, 2022
vivekshankar1
changed the title
SHIELD-71 Modified source of id_token.
SHIELD-71 SHIELD-78 Modified source of id_token.
Jun 21, 2022
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
vivekshankar1
force-pushed
the
SHIELD-64-security-fixes-of-session-cookie
branch
from
June 22, 2022 07:28
6a23308
to
3230b81
Compare
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
vivekshankar1
approved these changes
Jun 23, 2022
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Kudos, SonarCloud Quality Gate passed! |
shaik80
approved these changes
Jun 27, 2022
vivek-yadav
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Atul Krishna Atul.Krishna@progress.com
🔩 Description: What code changed, and why?
Removed id_token cookie and changed API flow to retrieve id_token from the HTTP response body.
Currently, the id_token cookie doesn't have Secure and HttpOnly attributes. While it is possible to add the Secure attribute but we cannot add the HttpOnly attribute in the id_token cookie as we are accessing this cookie via javascript to store it in the browser's local storage. Check here for more details.
The proposed solution is to modify the existing sign-in API flow to get id_token from /session/callback API's response body instead of the cookie.
⛓️ Related Resources
https://chefio.atlassian.net/browse/SHIELD-64
https://chefio.atlassian.net/browse/SHIELD-71
#6716
👍 Definition of Done
The /session/callback API should have id_token and state in response body.
👟 How to Build and Test the Change
Pull the changes from the source branch
Start automate
Rebuild session-service
Rebuild automate-dex
Open UI in browser with network tab
Check response of /session/callback API after login. It should have id_token and state value in the response body.
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Screen.Recording.2022-06-16.at.4.55.59.PM.mov