Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abdul/id token fix url #6716

Merged
merged 11 commits into from
Feb 23, 2022
Merged

Abdul/id token fix url #6716

merged 11 commits into from
Feb 23, 2022

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented Feb 18, 2022

🔩 Description: What code changed, and why?

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-14

👍 Definition of Done

id_token is stripped out of sign in/sign out flow from URL fragment.
Unit tests are working
cypress test is passed

👟 How to Build and Test the Change

rebuild components/automate-ui
rebuild components/session-service

#id_token should not come in URL at the time of sign in/sign out flow.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@iamazzeez iamazzeez added automate-auth Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues labels Feb 18, 2022
@iamazzeez iamazzeez self-assigned this Feb 18, 2022
@netlify
Copy link

netlify bot commented Feb 18, 2022

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 924546f

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6214ebd6979f4400086eae37

Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

15.0% 15.0% Coverage
4.4% 4.4% Duplication

@kalroy kalroy merged commit bdc4602 into main Feb 23, 2022
@kalroy kalroy deleted the abdul/id_token_fix_url branch February 23, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-auth Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants