-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abdul/id token fix url #6716
Merged
Merged
Abdul/id token fix url #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamazzeez
added
automate-auth
Team: Kinetic
Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues
labels
Feb 18, 2022
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 924546f 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6214ebd6979f4400086eae37 |
iamazzeez
force-pushed
the
abdul/id_token_fix_url
branch
from
February 21, 2022 07:42
4e96df2
to
31bcd6e
Compare
kalroy
approved these changes
Feb 22, 2022
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
iamazzeez
force-pushed
the
abdul/id_token_fix_url
branch
from
February 22, 2022 10:34
ca2b40c
to
5aa7845
Compare
Signed-off-by: Abdul-Az <aazeez@progress.com>
Kudos, SonarCloud Quality Gate passed! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automate-auth
Team: Kinetic
Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
⛓️ Related Resources
https://chefio.atlassian.net/browse/KINETICS-14
👍 Definition of Done
id_token is stripped out of sign in/sign out flow from URL fragment.
Unit tests are working
cypress test is passed
👟 How to Build and Test the Change
rebuild components/automate-ui
rebuild components/session-service
#id_token should not come in URL at the time of sign in/sign out flow.
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable