Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert rotate cmd for OS #7526

Merged
merged 6 commits into from
Nov 14, 2022
Merged

cert rotate cmd for OS #7526

merged 6 commits into from
Nov 14, 2022

Conversation

Sahiba3108
Copy link
Collaborator

@Sahiba3108 Sahiba3108 commented Nov 9, 2022

Signed-off-by: Sahiba3108 sgoyal@progress.com
SanjuPal01 sanju.sanju@progress.com

🔩 Description: What code changed, and why?

Added the cert rotate command for HA service. Now user has to pass the certificate paths to cert-rotate cmd and it will rotate the certificates of all opensearch nodes.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-231

👍 Definition of Done

👟 How to Build and Test the Change

Add this package in your manifest while deploying HA:
sahiba3108/automate-ha-deployment/0.1.0/20221028084038

Install this cli in your bastion host:
sahiba3108/automate-cli/0.1.0/20221111124650

Run the below command in bastion:
chef-automate cert-rotate --public-cert node1.pem --private-cert node1-key.pem --root-ca root-ca.pem --admin-cert admin.pem --admin-key admin-key.pem --os
(You can also use --opensearch flag instead of os)
This will rotate the public, private, root, admin cert and admin key of all os nodes.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2022-11-11 at 3 32 27 PM

Screenshot 2022-11-11 at 3 20 20 PM

Screenshot 2022-11-11 at 3 17 11 PM

Screenshot 2022-11-11 at 3 17 00 PM

Screenshot 2022-11-11 at 3 23 55 PM

Video Link: https://progresssoftware-my.sharepoint.com/:v:/g/personal/ssanju_progress_com/ETAARk9tnmZLpuw2axg4BooBoFSUrrKa2PMXsuvLf5942Q?e=kzFyMw

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 57b0b1a
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6371ddcfb09b5e00091ec399
😎 Deploy Preview https://deploy-preview-7526--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please modularise the code instead of writing the single function.

Dmaddu and others added 6 commits November 14, 2022 11:47
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
@Dmaddu Dmaddu merged commit b5ddf56 into main Nov 14, 2022
@Dmaddu Dmaddu deleted the kinetics-231/cert_rotate_os branch November 14, 2022 06:35
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

2.0% 2.0% Coverage
4.6% 4.6% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants