-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cert rotate cmd for OS #7526
Merged
Merged
cert rotate cmd for OS #7526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
punitmundra
requested changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please modularise the code instead of writing the single function.
5bd01dd
to
2522a80
Compare
9 tasks
Dmaddu
approved these changes
Nov 14, 2022
punitmundra
approved these changes
Nov 14, 2022
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
Signed-off-by: Sahiba3108 <sgoyal@progress.com>
00f6507
to
57b0b1a
Compare
SanjuPal01
approved these changes
Nov 14, 2022
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sahiba3108 sgoyal@progress.com
SanjuPal01 sanju.sanju@progress.com
🔩 Description: What code changed, and why?
Added the cert rotate command for HA service. Now user has to pass the certificate paths to cert-rotate cmd and it will rotate the certificates of all opensearch nodes.
⛓️ Related Resources
https://chefio.atlassian.net/browse/KINETICS-231
👍 Definition of Done
👟 How to Build and Test the Change
Add this package in your manifest while deploying HA:
sahiba3108/automate-ha-deployment/0.1.0/20221028084038
Install this cli in your bastion host:
sahiba3108/automate-cli/0.1.0/20221111124650
Run the below command in bastion:
chef-automate cert-rotate --public-cert node1.pem --private-cert node1-key.pem --root-ca root-ca.pem --admin-cert admin.pem --admin-key admin-key.pem --os
(You can also use --opensearch flag instead of os)
This will rotate the public, private, root, admin cert and admin key of all os nodes.
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Video Link: https://progresssoftware-my.sharepoint.com/:v:/g/personal/ssanju_progress_com/ETAARk9tnmZLpuw2axg4BooBoFSUrrKa2PMXsuvLf5942Q?e=kzFyMw