Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for remote certs #7536

Merged
merged 29 commits into from
Nov 25, 2022
Merged

Added support for remote certs #7536

merged 29 commits into from
Nov 25, 2022

Conversation

atultherajput
Copy link
Member

@atultherajput atultherajput commented Nov 11, 2022 •
edited
Loading

Signed-off-by: Atul Krishna Atul.Krishna@progress.com

🔩 Description: What code changed, and why?

Added support for remote certs in Automate HA.

⛓️ Related Resources

#7526
https://chefio.atlassian.net/browse/SHIELD-173

👍 Definition of Done

  • Cert rotate command should accept the remote path for certificate flag values.

  • Each flag value should accept either a remote path or a local path(but not both at the same time).

  • The remote path should be in one of the associated nodes of HA cluster.

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

automate-cmd-output-24

cs-cmd-output-24

MicrosoftTeams-image (8)

MicrosoftTeams-image (9)

MicrosoftTeams-image (10)

MicrosoftTeams-image (11)

Video: https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/Eae5hfRjmSBJvDNJiCSDYfgBJxhLq8fJZqBtyFfyIcitUQ?e=osjPOq

Base automatically changed from kinetics-231/cert_rotate_os to main November 14, 2022 06:35
@atultherajput atultherajput changed the base branch from main to 3x_banner_changes November 14, 2022 11:50
@atultherajput atultherajput changed the base branch from 3x_banner_changes to main November 14, 2022 11:50
@netlify
Copy link

netlify bot commented Nov 14, 2022 •
edited
Loading

✅ Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit b07df16
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/638088ee0d13ba000907a6e5
😎 Deploy Preview https://deploy-preview-7536--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atultherajput atultherajput changed the base branch from main to cert_rotate_cli_kinetics November 14, 2022 12:09
@atultherajput atultherajput changed the base branch from cert_rotate_cli_kinetics to main November 14, 2022 12:09
@atultherajput atultherajput changed the base branch from main to MADROX-294 November 14, 2022 12:21
@atultherajput atultherajput changed the base branch from MADROX-294 to main November 14, 2022 12:21
@atultherajput atultherajput force-pushed the akrishna/fetch-certs-from-remote branch 2 times, most recently from 7b0c679 to ead628a Compare November 14, 2022 13:12
@atultherajput atultherajput self-assigned this Nov 14, 2022
@atultherajput atultherajput force-pushed the akrishna/fetch-certs-from-remote branch 2 times, most recently from 7074686 to 4db2362 Compare November 15, 2022 06:31
@atultherajput atultherajput force-pushed the akrishna/fetch-certs-from-remote branch 5 times, most recently from bec2bbe to 121aee2 Compare November 15, 2022 13:41
atultherajput and others added 11 commits November 25, 2022 10:43
@atultherajput
Added doc change for remote path.
7d4c623 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Formatted notes
27396e4 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Added fileUtils.ReadFile mock
134364c 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Removed global variables and updated unittest case
0e229a5 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Merged flags structs
48fd7d2 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Rearranged structs
20940e3 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Created struct for certs
084b816 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@prasad927 @atultherajput
Added function descriptions
4c7188c 
Signed-off-by: prasad927 <Prasad.Chaudhari@progress.com>
@atultherajput
Moved add root command
0661238 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Renamed variables
b0712d3 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Updated output for scp
b53498b 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput
Copy link
Member Author

@atultherajput please make the changes as per the above discussion to provide the approval, rest are good

@Dmaddu I have pushed the changes as per the disccusion.

@atultherajput
Rearranged fileutils code
e747322 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@Sahiba3108 Sahiba3108 self-requested a review November 25, 2022 06:07
@atultherajput
Updated doc
b07df16 
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

47.3% 47.3% Coverage
0.0% 0.0% Duplication

@vivekshankar1 vivekshankar1 merged commit 4bf26b4 into main Nov 25, 2022
@vivekshankar1 vivekshankar1 deleted the akrishna/fetch-certs-from-remote branch November 25, 2022 10:04
@atultherajput atultherajput mentioned this pull request Nov 30, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app left review comments

@vivek-yadav vivek-yadav vivek-yadav approved these changes

@Dmaddu Dmaddu Dmaddu approved these changes

@vivekshankar1 vivekshankar1 vivekshankar1 approved these changes

@dishanktiwari2501 dishanktiwari2501 dishanktiwari2501 approved these changes

@prasad927 prasad927 prasad927 approved these changes

@SanjuPal01 SanjuPal01 SanjuPal01 approved these changes

@Sahiba3108 Sahiba3108 Sahiba3108 approved these changes

@shaik80 shaik80 Awaiting requested review from shaik80

@punitmundra punitmundra Awaiting requested review from punitmundra

@kalroy kalroy Awaiting requested review from kalroy

@jayvikramsharma1 jayvikramsharma1 Awaiting requested review from jayvikramsharma1

@iamazzeez iamazzeez Awaiting requested review from iamazzeez

Assignees

@atultherajput atultherajput

@prasad927 prasad927

Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@atultherajput @Dmaddu @vivek-yadav @vivekshankar1 @dishanktiwari2501 @prasad927 @SanjuPal01 @Sahiba3108 @kalroy