Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/chef server config #7572

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Feature/chef server config #7572

merged 5 commits into from
Dec 12, 2022

Conversation

daveaugustus
Copy link
Contributor

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

YashviJain01 and others added 3 commits November 23, 2022 11:37
* Adding configuration for datacollector for chef server

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding correct value

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding correct value

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
* Added config for cs_nginx

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* changed the config value for chef server

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* PR comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
* Just a draft PR

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Config changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Revert changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Done configuration changes one config key added

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* pr comment fixed

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
@netlify
Copy link

netlify bot commented Nov 28, 2022

βœ… Deploy Preview for chef-automate ready!

Name Link
πŸ”¨ Latest commit 0b0d127
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/638ed82039a7760008f9a25f
😎 Deploy Preview https://deploy-preview-7572--chef-automate.netlify.app/versions
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

daveaugustus and others added 2 commits November 29, 2022 19:45
* Just a draft PR

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Config changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* updated proto file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Proto compiled

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Rebased

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Setup default values

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Updated sys.config

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* ERRor fixed

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Made changes to sys.config file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Done with test cases

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* changed made based on the PR comments

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Working code

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* fixed untouched lines and files

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* fixed untouched lines and files

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
* created a page for the list of parameters of chef server in chef automate

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* test

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* added a column to the table

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* added a column to the table with code snippet

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* updated the doc with data

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* config doc

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Modified the doc

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* fixed some minor changes

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* updated the link

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Dec 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy marked this pull request as ready for review December 12, 2022 04:42
@kalroy kalroy requested a review from a team as a code owner December 12, 2022 04:42
@kalroy kalroy self-requested a review December 12, 2022 04:42
@kalroy kalroy merged commit 3b15df7 into main Dec 12, 2022
@kalroy kalroy deleted the feature/chef_server_config branch December 12, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants