Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Bifrost using Automate config #7554

Merged
merged 5 commits into from
Nov 25, 2022

Conversation

daveaugustus
Copy link
Contributor

@daveaugustus daveaugustus commented Nov 21, 2022

Signed-off-by: Pappu Kumar pappu.kumar@progress.com

🔩 Description: What code changed, and why?

As an Automate admin, I want to configure bifrost services of Chef Server in Automate and Automate HA using chef-automate config patch file.toml

⛓️ Related Resources

👍 Definition of Done

  • The configuration needs to be patchable via chef-automate config patch
  • The default configuration needs to be set as per the Standalone Chef Server values
  • In case of Automate HA, if there is a different default, that needs to be set in the config.toml.erb file
  • The Standalone Automate needs to be deployed and tested to see if all the service configurations are in place
  • The Automate deployed Chef Server should be running fine
  • The Automate HA needs to be deployed and tested to see if all the service configurations for Chef Server are in place
  • The Automate deployed Chef Server in HA should be running fine
  • All the changed values need to be documented

👟 How to Build and Test the Change

rebuild components/automate-deployment/
rebuild components/automate-cli/
rebuild components/automate-cs-oc-bifrost/
  • Adde the following conf to a abc.toml file
[bifrost.v1.sys.log]
    extended_perf_log = false

and patch using the following command
chef-automate config patch abc.toml

The result should look like the following image if you run the following command:

cat /hab/svc/automate-cs-oc-bifrost/config/sys.config

Screenshot 2022-11-24 at 9 46 05 PM

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@daveaugustus daveaugustus self-assigned this Nov 21, 2022
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@daveaugustus daveaugustus changed the title Just a draft PR Configure Bifrost using Automate config Nov 22, 2022
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the config:
oc_bifrost['extended_perf_log']

api/config/bifrost/config_request.go Outdated Show resolved Hide resolved
api/config/bifrost/config_request.proto Outdated Show resolved Hide resolved
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@netlify
Copy link

netlify bot commented Nov 24, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 2ec8f65
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63806984ccf1f500081949ca

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@daveaugustus daveaugustus marked this pull request as ready for review November 24, 2022 16:24
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@daveaugustus
Copy link
Contributor Author

Working fine on automate standalone
Screenshot 2022-11-25 at 1 14 23 PM

@kalroy kalroy merged commit 29cc4a1 into feature/chef_server_config Nov 25, 2022
@kalroy kalroy deleted the dave/STALWART-266 branch November 25, 2022 11:33
kalroy pushed a commit that referenced this pull request Dec 12, 2022
* Adding configuration for datacollector for chef server (#7553)

* Adding configuration for datacollector for chef server

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding correct value

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding correct value

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Added config for cs_nginx (#7555)

* Added config for cs_nginx

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* changed the config value for chef server

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* PR comments

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>

* Configure Bifrost using Automate config (#7554)

* Just a draft PR

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Config changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Revert changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Done configuration changes one config key added

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* pr comment fixed

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>

* Dave/stalwart 262 (#7567)

* Just a draft PR

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Config changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* updated proto file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Proto compiled

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Rebased

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Setup default values

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Updated sys.config

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* ERRor fixed

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Made changes to sys.config file

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Done with test cases

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* changed made based on the PR comments

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Working code

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* fixed untouched lines and files

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* fixed untouched lines and files

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Chef Server settings with Default Values (#7558)

* created a page for the list of parameters of chef server in chef automate

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* test

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* added a column to the table

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* added a column to the table with code snippet

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* updated the doc with data

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* config doc

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* Modified the doc

Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>

* fixed some minor changes

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

* updated the link

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>

Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>
Co-authored-by: Yashvi Jain <91940132+YashviJain01@users.noreply.github.com>
Co-authored-by: SahithiMy <98326242+SahithiMy@users.noreply.github.com>
Co-authored-by: SahithiMy <sahithi.mylangam@progress.com>
Co-authored-by: Dave Augustus <36985548+dave-augustus@users.noreply.github.com>
Co-authored-by: Dishank Tiwari <dtiwari@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants