Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the max_request_size to 4MB #7783

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Mar 16, 2023

🔩 Description: What code changed, and why?

We need to set the default value for chef_server_default_max_size to 4MB instead of 2MB.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-1471
https://chefio.atlassian.net/browse/IN-969

👍 Definition of Done

  • The config size should be set in the opscode_erchef['max_request_size'] in /etc/opscode/chef-server.rb files in CS nodes in case of Automate HA and in the Automate instance

👟 How to Build and Test the Change

  • hab studio enter
  • start_all_services
  • start_chef_server
  • check the config

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 0b078e1
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6417f4cff326fc0008e7144e
😎 Deploy Preview https://deploy-preview-7783--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@Dmaddu Dmaddu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add doc changes as well to this PR?

Signed-off-by: Kallol Roy <kallol.roy@progress.com>
@kalroy kalroy requested a review from a team as a code owner March 20, 2023 05:53
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Mar 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmaddu Dmaddu merged commit f316361 into main Mar 20, 2023
@Dmaddu Dmaddu deleted the chef_server_default_max_size branch March 20, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants