Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_group_name added #7819

Merged
merged 4 commits into from
Apr 15, 2023
Merged

ssh_group_name added #7819

merged 4 commits into from
Apr 15, 2023

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented Apr 13, 2023

🔩 Description: What code changed, and why?

https://chefio.atlassian.net/browse/CHEF-2054

⛓️ Related Resources

👍 Definition of Done

Initialised Automate HA On Prem infra
added custom groupname on all the automate HA nodes

sudo groupadd aazeez
sudo usermod -a -G aazeez ec2-user

Screenshot 2023-04-14 at 4 34 37 PM

Screenshot 2023-04-14 at 4 35 03 PM

Screenshot 2023-04-14 at 4 36 43 PM

👟 How to Build and Test the Change

  • Rebuild automate-cli (rebuild components/automate-cli/) or can use (aazeez/automate-cli/0.1.0/20230414122935), automate-ha-cluster-ctl (rebuild components/automate-cluster-ctl/) or can use (aazeez/automate-ha-cluster-ctl/0.1.0/20230413171357), and automate-ha-deployment(rebuild components/automate-backend-deployment/) or can use (aazeez/automate-ha-deployment/0.1.0/20230413175551`).
  • Upload the above packages hab pkg upload <PATH_TO_PACKAGE_HART_FILE>.
  • Create an airgap bundle with new packages sudo ./chef-automate airgap bundle create -m latest_semver.json --channel dev. Update this latest_semver.json manifest file with your origins.
  • Note: Do not update the automate-cli origin in the manifest file, just install the new automate-cli on Bastion.

hab pkg install -bf aazeez/automate-cli/0.1.0/20230414122935

Create custom group name in all Automate HA nodes
To create custom group
sudo groupadd groupname

To add ec2-user to custom group
sudo usermod -a -G groupname ec2-user

Modify config.toml ssh_group_name value with same groupname added in HA nodes and deploy

Note: if ssh_group_name is not provided it will be defaulted to ssh_user

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 570b1df
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6439a5253b1145000895dddc
😎 Deploy Preview https://deploy-preview-7819--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@iamazzeez iamazzeez marked this pull request as draft April 13, 2023 20:23
@iamazzeez iamazzeez marked this pull request as ready for review April 13, 2023 20:24
iamazzeez and others added 4 commits April 15, 2023 00:39
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
8.3% 8.3% Duplication

@Dmaddu Dmaddu merged commit b5ef506 into main Apr 15, 2023
@Dmaddu Dmaddu deleted the abdul/CHEF-2054 branch April 15, 2023 09:46
SanjuPal01 pushed a commit that referenced this pull request Apr 17, 2023
* ssh_group_name added

Signed-off-by: Abdul-Az <aazeez@progress.com>

* fixed cli error

Signed-off-by: Abdul-Az <aazeez@progress.com>

* fix

Signed-off-by: Abdul-Az <aazeez@progress.com>

* pipeline fix

Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>

---------

Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Durga Sarat Chandra Maddu <dmaddu@progress.com>
Co-authored-by: dmaddu <dmaddu@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants