-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to make OS and PG fields optional for managed setup #7939
Merged
vivek-yadav
merged 2 commits into
main
from
sandhi/make-os-pg-config-nonmanadate-for-managed
Jun 2, 2023
Merged
Changes to make OS and PG fields optional for managed setup #7939
vivek-yadav
merged 2 commits into
main
from
sandhi/make-os-pg-config-nonmanadate-for-managed
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sandhi <sagarwal@progress.com>
sandhi18
requested review from
vivek-yadav,
rishabhjhs,
atultherajput,
jayvikramsharma1,
punitmundra,
ArvinthC3000,
vivekshankar1,
vviveksharma,
karunesh-tech,
vipin230 and
bvtejaswi
June 2, 2023 06:05
👷 Deploy Preview for chef-automate processing.
|
ArvinthC3000
approved these changes
Jun 2, 2023
vivek-yadav
approved these changes
Jun 2, 2023
punitmundra
approved these changes
Jun 2, 2023
Signed-off-by: sandhi <sagarwal@progress.com>
rishabhjhs
approved these changes
Jun 2, 2023
vviveksharma
approved these changes
Jun 2, 2023
vipin230
approved these changes
Jun 2, 2023
Sunanda-Boorla
approved these changes
Jun 2, 2023
atultherajput
approved these changes
Jun 2, 2023
vivekshankar1
approved these changes
Jun 2, 2023
bvtejaswi
approved these changes
Jun 2, 2023
SonarQube Quality Gate Maintainability Rating on New Code (is worse than A) See analysis details on SonarQube Fix issues before they fail your Quality Gate with SonarLint in your IDE. |
YashviJain01
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Changes to make OS an dPG fields optional Signed-off-by: sandhi <sagarwal@progress.com> * Feedback comment Signed-off-by: sandhi <sagarwal@progress.com> --------- Signed-off-by: sandhi <sagarwal@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Added the changes to make the OS instance count and OS instance type along with PG instance count and PG instance type as optional for the managed setup.
These changes are applicable for both AWS and Onprem setup
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-3206
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/Eecj8a3gf95Pq0HukGrgmOIBc6spTJgeuU9o1R6zfuvVkA?e=UXRHYS
https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/ESjqnymm8FtLqTPdpQHEd7oBSIBwcegWZWJ99ouo8RuyXQ?e=4CsqFk