-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/nightly] Build ALL components during nightly build #840
Conversation
scripts/verify_build.sh
Outdated
else | ||
mapfile -t changed_components < <(./scripts/changed_components.rb) | ||
if [[ ${#changed_components[@]} -ne 0 ]]; then | ||
cat << EOF | buildkite-agent annotate --style "info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Let's free that cat:
cat << EOF | buildkite-agent annotate --style "info" | |
buildkite-agent annotate --style "info" <<EOF |
(I'm aware that this was just moved, feel free to ignore. 😉 )
2912d2e
to
15d05cc
Compare
@@ -227,22 +227,6 @@ function rebuild() { | |||
return $err | |||
} | |||
|
|||
document "build_all" <<DOC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function could not have been working for people since many of the packages it would have built do not build. Thus, I've removed it since it implies people don't use it.
We periodically find that components no longer build because of dependency changes. We typically find out that these components don't build when developers are doing cleanup or maintenance work such as updating dependencies. Only finding build problems during such tasks increases the cost of starting such tasks and means that we discover the problems long after the change that produced the problem, making it harder to debug. Currently, the nightly builds only rebuild whatever changed in the latest commit to master, using the same changed components logic that the rest of our verify pipelines use. This changes the nightlies to build all components, which should allow us to discover build issues more promptly, divorced from any particular change. Signed-off-by: Steven Danna <steve@chef.io>
f9df55b
to
7d18e10
Compare
It passed the nightly! https://buildkite.com/chef/chef-automate-master-nightly/builds/94 |
We periodically find that components no longer build because of
dependency changes. We typically find out that these components don't
build when developers are doing cleanup or maintenance work such as
updating dependencies. Only finding build problems during such tasks
increases the cost of starting such tasks and means that we discover
the problems long after the change that produced the problem, making
it harder to debug.
Currently, the nightly builds only rebuild whatever changed in the
latest commit to master, using the same changed components logic that
the rest of our verify pipelines use.
This changes the nightlies to build all components, which should allow
us to discover build issues more promptly, divorced from any
particular change.
Signed-off-by: Steven Danna steve@chef.io
🔩 Description
👍 Definition of Done
👟 Demo Script / Repro Steps
⛓️ Related Resources
✅ Checklist