[CI/nightly] Build ALL components during nightly build #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Jul 10, 2019
scripts/verify_build.sh
Outdated
| else | ||
| mapfile -t changed_components < <(./scripts/changed_components.rb) | ||
| if [[ ${#changed_components[@]} -ne 0 ]]; then | ||
| cat << EOF | buildkite-agent annotate --style "info" |
There was a problem hiding this comment.
[nit] Let's free that cat:
Suggested change
| cat << EOF | buildkite-agent annotate --style "info" | |
| buildkite-agent annotate --style "info" <<EOF |
(I'm aware that this was just moved, feel free to ignore. 😉 )
stevendanna
force-pushed
the
ssd/nightly-build-all
branch
from
2912d2e
to
15d05cc
Compare
stevendanna
commented
Jul 10, 2019
| @@ -227,22 +227,6 @@ function rebuild() { | |||
| return $err | |||
| } | |||
|
|
|||
| document "build_all" <<DOC | |||
There was a problem hiding this comment.
This function could not have been working for people since many of the packages it would have built do not build. Thus, I've removed it since it implies people don't use it.
We periodically find that components no longer build because of dependency changes. We typically find out that these components don't build when developers are doing cleanup or maintenance work such as updating dependencies. Only finding build problems during such tasks increases the cost of starting such tasks and means that we discover the problems long after the change that produced the problem, making it harder to debug. Currently, the nightly builds only rebuild whatever changed in the latest commit to master, using the same changed components logic that the rest of our verify pipelines use. This changes the nightlies to build all components, which should allow us to discover build issues more promptly, divorced from any particular change. Signed-off-by: Steven Danna <steve@chef.io>
stevendanna
force-pushed
the
ssd/nightly-build-all
branch
from
f9df55b
to
7d18e10
Compare
|
It passed the nightly! https://buildkite.com/chef/chef-automate-master-nightly/builds/94 |
tduffield
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We periodically find that components no longer build because of
dependency changes. We typically find out that these components don't
build when developers are doing cleanup or maintenance work such as
updating dependencies. Only finding build problems during such tasks
increases the cost of starting such tasks and means that we discover
the problems long after the change that produced the problem, making
it harder to debug.
Currently, the nightly builds only rebuild whatever changed in the
latest commit to master, using the same changed components logic that
the rest of our verify pipelines use.
This changes the nightlies to build all components, which should allow
us to discover build issues more promptly, divorced from any
particular change.
Signed-off-by: Steven Danna steve@chef.io
🔩 Description
👍 Definition of Done
👟 Demo Script / Repro Steps
⛓️ Related Resources
✅ Checklist