automate-gateway: make unknown data cause an error #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
added
automate-gateway
tech debt
srenatus
force-pushed
the
sr/automate-gateway/unknown-data-is-an-error-now
branch
2 times, most recently
from
6fce58a
to
2086804
Compare
|
Turns out this affects a few of our inspec tests... might continue looking into this later... |
Before, if you (for example) POST
{ "foo": "bar", "baz": 300 }
where the protobuf message this is to be converted into only has a field
string foo = 1;
this would silently be ignored.
Now, it's an error:
{
"error": "unknown field \"bar\" in request.CreateProjectReq",
"message": "unknown field \"bar\" in request.CreateProjectReq",
"code": 3,
"details": []
}
Signed-off-by: Stephan Renatus <srenatus@chef.io>
It's never been a thing -- and now automate-gateway will complain. Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus
force-pushed
the
sr/automate-gateway/unknown-data-is-an-error-now
branch
from
2086804
to
73f162d
Compare
…serReq Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus
force-pushed
the
sr/automate-gateway/unknown-data-is-an-error-now
branch
from
18575e2
to
47afce7
Compare
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
|
To be discussed, reopened, eventually. I'll make a tech debt card. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if you (for example) POST
where the protobuf message this is to be converted into only has a field
this would silently be ignored.
Now, it's an error: