Update Hyper-V Parameters to new conventions #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Ferguson <joe@joeferguson.me>
svpernova09
changed the title
cheeseplus
approved these changes
Jul 23, 2019
|
@svpernova09 Great stuff. Thanks for the cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Ferguson joe@joeferguson.me
Description
Resolves the Hyper-V issues brought up in #1194 with wrong params/variable names
Issues Resolved
Resolves #1194
Here's a Gist of running
packer validate ...against each of the changed files. Looks like there are some VMware issues to be addressed, no errors or warnings for Hyper-V.