Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qemu_format="raw" causing wrong format for qemu #1568

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix qemu_format="raw" causing wrong format for qemu #1568

merged 1 commit into from
May 23, 2024

Conversation

saily
Copy link
Contributor

@saily saily commented May 22, 2024

Description

Setting qemu_format to raw in os_pkrvars directory causes wrong disk format being injected into local.qemuargs.

Related Issue

  • None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Stromweld Stromweld marked this pull request as ready for review May 23, 2024 14:34
@Stromweld Stromweld requested review from Stromweld and a team as code owners May 23, 2024 14:34
Stromweld
Stromweld approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks.

@Stromweld Stromweld merged commit 036e8d1 into chef:main May 23, 2024
66 of 256 checks passed
hunleyd added a commit to hunleyd/bento that referenced this pull request May 24, 2024
@hunleyd
Merge branch 'main' of github.com:chef/bento
d39c480 
* 'main' of github.com:chef/bento:
  setup workflow for hosted runners (chef#1547)
  Fix qemu_format="raw" causing wrong format for qemu (chef#1568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stromweld Stromweld Stromweld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saily @Stromweld