Update to use coverage/ and upload artifacts

Signed-off-by: Salim Afiune <afiune@chef.io>

.expeditor/verify.pipeline.yml

@@ -17,6 +17,8 @@ steps:
   - label: ":linux: go-unit-code-coverage"
     command:
       - ./scripts/code_coverage.sh
+    artifact_paths:
+      - "coverage/*"
     expeditor:
       secrets:
         GITHUB_TOKEN:

.gitignore

@@ -4,6 +4,7 @@
 
 # Habitat
 results/
+coverage/
 
 # mac
 .DS_Store

.studiorc

@@ -5,9 +5,10 @@
 hab pkg install chef/studio-common >/dev/null
 source "$(hab pkg path chef/studio-common)/bin/studio-common"
 
-coverage_out="results/coverage.raw"
-coverage_txt="results/coverage.txt"
-coverage_html="results/coverage.html"
+# when updating these output files, update 'scripts/code_coverage.sh' as well
+coverage_out="coverage/coverage.raw"
+coverage_txt="coverage/coverage.txt"
+coverage_html="coverage/coverage.html"
 
 function build_cross_platform() {
   install_if_missing core/go go
@@ -34,7 +35,7 @@ function unit_tests() {
   log_line "Running unit tests"
   # Avoid running integration tests inside unit tests
   ( cd /src || return 1
-    mkdir -p results/
+    mkdir -p coverage/
     GO_PACKAGES=$(go list ./... | grep -v integration)
     go test \
       -coverprofile=$coverage_out \
@@ -45,7 +46,7 @@ function unit_tests() {
 # run unit tests plus code coverage information
 function code_coverage() {
   ( cd /src || return 1
-    mkdir -p results/
+    mkdir -p coverage/
     unit_tests
     log_line "Generating coverage profile information for each function ($(yellow /src/$coverage_txt))"
     go tool cover -func=$coverage_out -o  $coverage_txt

scripts/code_coverage.sh

@@ -3,7 +3,7 @@
 set -euo pipefail
 
 # the generated code coverage profile coming from our habitat studio
-COVERAGE_TXT="results/coverage.txt"
+COVERAGE_TXT="coverage/coverage.txt"
 # extract the repository name from the environment variable BUILDKITE_REPO
 # example: "https://github.com/chef/chef-analyze.git"
 REPO_NAME=$(echo $BUILDKITE_REPO | cut -d/ -f5 | cut -d. -f1)
@@ -27,4 +27,4 @@ EOF
 
 hab studio run "source .studiorc && code_coverage"
 
-curl -H "Authorization: token $GITHUB_TOKEN" "$COMMENTS_URL" -d "$(post_data)"
+curl -H "Authorization: token $GITHUB_TOKEN" "$COMMENTS_URL" -d "$(post_data)" >/dev/null