Remove references to patched version of net/http #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up on the previous commit which was merged a little too soon. The net/http monkeypatch was removed from chef when b58460543a03e5e317637315b647d7ed74f0380f was merged via chef/chef#10548 This means request data is no longer available in Net::HTTPException. There's no option to get it back short of a new monkeypatch to inject at origin, which is what we just removed in chef 16. This change change removes our usage of it in chef-cli. This means that exception inspector will no longer no longer provide request data in its output for net/http exceptions. Also patched up a couple of places where we referred to Net:: constants without requiring them first. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on the previous commit which was merged a little too
soon.
The net/http monkeypatch was removed from chef when
b58460543a03e5e317637315b647d7ed74f0380f was merged
via chef/chef#10548
This means request data is no longer available in Net::HTTPException.
There's no option to get it back short of a new monkeypatch
to inject at origin, which is what we just removed in chef 16.
This change change removes our usage of it in chef-cli.
Exception inspector will no longer
no longer provide request data in its output for net/http exceptions.
Also patched up a couple of places where we referred to Net::
constants without requiring them first.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com